net/dns: Fix the last warning found by chromium-style clang plugin on Windows.

net/dns: Fix the last warning found by chromium-style clang plugin on Windows.

This fixes the following kind of warnings:

warning(clang): [chromium-style] Complex class/struct needs an explicit out-of-line constructor.
warning(clang): [chromium-style] Complex class/struct needs an explicit out-of-line destructor.

http://build.chromium.org/p/chromium.fyi/builders/CrWinClang/builds/687/steps/compile/logs/stdio

BUG=467287
Committed: https://crrev.com/916335e69a37c00a6b6b2e6d6f6230c1a26d28d5
Cr-Commit-Position: refs/heads/master@{#329074}

[Nico, 2015-05-08 20:26:05]

thakis@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Nico, 2015-05-08 20:26:05]

Not super great, but it's the last warning.

[Ryan Sleevi, 2015-05-08 21:01:30]

The CQ bit was checked by rsleevi@chromium.org

[Ryan Sleevi, 2015-05-08 21:01:31]

lgtm

[commit-bot: I haz the power, 2015-05-08 21:02:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130873007/20001

[Nico, 2015-05-08 21:19:32]

e:\b\build\slave\win\build\src\net\dns\dns_config_service_win_unittest.cc(397) :
fatal error C1001: An internal error has occurred in the compiler.

O_o

[Nico, 2015-05-08 22:15:01]

I added a somewhat ugly workaround for that MSVS bug (I also have a reduced
repro; at the end of this post), together with a TODO on me to clean that up
once it's fixed in msvs.

Repro:

C:\src\chrome\src\third_party\llvm-build\Release+Asserts>type
c:\src\chrome\src\net\dns\dns_config_service_win_unittest.cc
#include <winsock2.h>
#include <iphlpapi.h>

#include <memory>
#include <string>

struct DnsSystemSettings {
  struct RegString {
    bool set;
    std::wstring value;
  };

  DnsSystemSettings(
      std::unique_ptr<IP_ADAPTER_ADDRESSES> addresses,
      const RegString& policy_search_list);
  ~DnsSystemSettings();
};

std::unique_ptr<IP_ADAPTER_ADDRESSES> CreateAdapterAddresses() {
  std::unique_ptr<IP_ADAPTER_ADDRESSES> heap;
  return heap;
}

void f() {
  const struct TestCase {
    DnsSystemSettings input_settings;
  } cases[] = {
    {
      {
        CreateAdapterAddresses(),
        { true, L"policy.searchlist.a,policy.searchlist.b" },
      },
    },
  };
  (void) cases;
}

C:\src\chrome\src\third_party\llvm-build\Release+Asserts>cl /c
c:\src\chrome\src\net\dns\dns_config_service_win_unittest.cc
Microsoft (R) C/C++ Optimizing Compiler Version 18.00.31101 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

dns_config_service_win_unittest.cc
c:\src\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\include\xlocale(337)
: warning C4530: C++ exception handler used,
ind semantics are not enabled. Specify /EHsc
c:\src\chrome\src\net\dns\dns_config_service_win_unittest.cc(36) : fatal error
C1001: An internal error has occurred in the compiler.
(compiler file 'f:\dd\vctools\compiler\utc\src\p2\ehexcept.c', line 956)
 To work around this problem, try simplifying or changing the program near the
locations listed above.
Please choose the Technical Support command on the Visual C++
 Help menu, or open the Technical Support help file for more information

[Nico, 2015-05-08 22:15:07]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-05-08 22:15:07]

The patchset sent to the CQ was uploaded after l-g-t-m from rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/1130873007/#ps40001
(title: "msvc crash workaround")

[commit-bot: I haz the power, 2015-05-08 22:15:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130873007/40001

[commit-bot: I haz the power, 2015-05-09 02:36:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-09 02:36:25]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  cast_shell_android on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Nico, 2015-05-10 05:10:54]

The test failure seems to be a silent miscompile produced by cl.exe:


C:\src\chromefetch\src>type test.cc
#include <string>
using namespace std;

struct DnsSystemSettings {
  struct RegString {
    bool set;
    wstring value;
  };

  DnsSystemSettings(const RegString& policy_search_list,
                    const RegString& primary_dns_suffix);

  RegString policy_search_list;
  RegString primary_dns_suffix;
};

DnsSystemSettings::DnsSystemSettings(const RegString& policy_search_list,
                                     const RegString& primary_dns_suffix)
    : policy_search_list(policy_search_list),
      primary_dns_suffix(primary_dns_suffix) {
}

int main() {
  DnsSystemSettings t = {
    { false },
    { true, L"primary.dns.suffix" },
  };

  fprintf(stderr, "%d %ls\n%d %ls\n",
        t.policy_search_list.set, t.policy_search_list.value.c_str(),
        t.primary_dns_suffix.set, t.primary_dns_suffix.value.c_str());
}

C:\src\chromefetch\src>cl test.cc
Microsoft (R) C/C++ Optimizing Compiler Version 18.00.31101 for x86
Copyright (C) Microsoft Corporation.  All rights reserved.

test.cc
c:\src\chrome\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\includ
e\xlocale(337) : warning C4530: C++ exception handler used, but unwind semantics
 are not enabled. Specify /EHsc
Microsoft (R) Incremental Linker Version 12.00.31101.0
Copyright (C) Microsoft Corporation.  All rights reserved.

/out:test.exe
test.obj

C:\src\chromefetch\src>test
0
1



clang gets this right:

C:\src\chromefetch\src>c:\src\llvm-rw-build-rel\bin\clang-cl test.cc

C:\src\chromefetch\src>test
0
1 primary.dns.suffix




Scary :-(

[Nico, 2015-05-10 05:28:50]

I rewrote this to not use a move constructor to work around that compiler bug
(they're not allowed anyway, I suppose). I'm going to hit cq, but maybe take
another look. I kind of like what I have now better than what I had originally.

[Nico, 2015-05-10 05:28:55]

The CQ bit was checked by thakis@chromium.org

[Nico, 2015-05-10 05:28:55]

The patchset sent to the CQ was uploaded after l-g-t-m from rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/1130873007/#ps100001
(title: "nicer")

[commit-bot: I haz the power, 2015-05-10 05:29:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130873007/100001

[Nico, 2015-05-10 05:33:12]

*"to not use a uniform initializer", not "to not use a move constructor"

On Sat, May 9, 2015 at 10:29 PM, <commit-bot@chromium.org> wrote:

> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1130873007/100001
>
>
> https://codereview.chromium.org/1130873007/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2015-05-10 09:29:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-10 09:29:57]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  cast_shell_android on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[Nico, 2015-05-10 15:29:34]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-05-10 15:30:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130873007/100001

[commit-bot: I haz the power, 2015-05-10 16:47:01]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-05-10 16:48:53]

Patchset 6 (id:??) landed as
https://crrev.com/916335e69a37c00a6b6b2e6d6f6230c1a26d28d5
Cr-Commit-Position: refs/heads/master@{#329074}