dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart - Issue 11308347: Fix crash on factory redirection to an unresolved class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 11308347: Fix crash on factory redirection to an unresolved class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart ('k') | dart/tests/language/language_dart2js.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart b/dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

index bb45083a3b197687fd74f24d44e8b2043e724c42..ca91ef69cf76e9513b032e63eda87e0237bee949 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart

@@ -3277,9 +3277,9 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {

return;

}

- if (constructor.getEnclosingClass().isAbstract(compiler) &&

- constructor.isGenerativeConstructor()) {

- generateAbstractClassInstantiationError(node, type.name.slowToString());

+ ClassElement cls = constructor.getEnclosingClass();

+ if (cls.isAbstract(compiler) && constructor.isGenerativeConstructor()) {

+ generateAbstractClassInstantiationError(node, cls.name.slowToString());

return;

}

if (compiler.world.needsRti(constructor.enclosingElement)) {