Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2485)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 11308347: Fix crash on factory redirection to an unresolved class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart b/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart
index f9bd17618db11285c38675d1db8eea22216f4293..3c8eebcc45640e4a9192a400b7eb07b3b0d032b6 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart
@@ -2033,6 +2033,9 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {
!redirectionTarget.modifiers.isConst()) {
error(node, MessageKind.CONSTRUCTOR_IS_NOT_CONST);
}
+ constructor.defaultImplementation = redirectionTarget;
+ if (Elements.isUnresolved(redirectionTarget)) return;
+
// TODO(ahe): Check that this doesn't lead to a cycle. For now,
// just make sure that the redirection target isn't itself a
// redirecting factory.
« no previous file with comments | « no previous file | dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698