Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2054)

Unified Diff: chrome/browser/extensions/component_loader.cc

Issue 11308302: Delete the old extension-based script bubble. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/component_loader.h ('k') | chrome/browser/extensions/page_action_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/component_loader.cc
===================================================================
--- chrome/browser/extensions/component_loader.cc (revision 170599)
+++ chrome/browser/extensions/component_loader.cc (working copy)
@@ -20,7 +20,6 @@
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_file_util.h"
#include "chrome/common/extensions/extension_manifest_constants.h"
-#include "chrome/common/extensions/feature_switch.h"
#include "chrome/common/pref_names.h"
#include "content/public/browser/notification_details.h"
#include "content/public/browser/notification_source.h"
@@ -89,13 +88,6 @@
ClearAllRegistered();
}
-const Extension* ComponentLoader::GetScriptBubble() const {
- if (script_bubble_id_.empty())
- return NULL;
-
- return extension_service_->extensions()->GetByID(script_bubble_id_);
-}
-
void ComponentLoader::LoadAll() {
for (RegisteredComponentExtensions::iterator it =
component_extensions_.begin();
@@ -313,14 +305,6 @@
#endif
}
-void ComponentLoader::AddScriptBubble() {
- if (FeatureSwitch::script_bubble()->IsEnabled()) {
- script_bubble_id_ =
- Add(IDR_SCRIPT_BUBBLE_MANIFEST,
- FilePath(FILE_PATH_LITERAL("script_bubble")));
- }
-}
-
// static
void ComponentLoader::EnableBackgroundExtensionsForTesting() {
enable_background_extensions_during_testing = true;
@@ -382,7 +366,6 @@
AddChromeApp();
#endif
- AddScriptBubble();
AddDefaultComponentExtensionsWithBackgroundPages();
}
« no previous file with comments | « chrome/browser/extensions/component_loader.h ('k') | chrome/browser/extensions/page_action_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698