Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5058)

Unified Diff: chrome/browser/extensions/page_action_controller.cc

Issue 11308302: Delete the old extension-based script bubble. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/page_action_controller.cc
===================================================================
--- chrome/browser/extensions/page_action_controller.cc (revision 170599)
+++ chrome/browser/extensions/page_action_controller.cc (working copy)
@@ -38,19 +38,8 @@
ExtensionActionManager* extension_action_manager =
ExtensionActionManager::Get(profile());
- // The script bubble, if present, is always first. This will make it show up
- // last in the omnibox.
- const Extension* script_bubble =
- service->component_loader()->GetScriptBubble();
- if (script_bubble)
- current_actions.push_back(
- extension_action_manager->GetPageAction(*script_bubble));
-
for (ExtensionSet::const_iterator i = service->extensions()->begin();
i != service->extensions()->end(); ++i) {
- if (script_bubble && *i == script_bubble)
- continue;
-
ExtensionAction* action = extension_action_manager->GetPageAction(**i);
if (action)
current_actions.push_back(action);
« no previous file with comments | « chrome/browser/extensions/component_loader.cc ('k') | chrome/browser/resources/component_extension_resources.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698