Issue 11308302: Delete the old extension-based script bubble.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11308302: Delete the old extension-based script bubble. (Closed)

Created:
8 years ago by Finnur

Modified:
8 years ago

Reviewers:
Aaron Boodman, James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews), chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Delete the old extension-based script bubble. BUG=153137 TEST=None, deleting code that is no longer used.

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -144 lines)			Patch
M	chrome/browser/browser_resources.grd	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/component_loader.h	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/extensions/component_loader.cc	View	4 chunks	+0 lines, -17 lines	0 comments	Download
M	chrome/browser/extensions/page_action_controller.cc	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	chrome/browser/resources/component_extension_resources.grd	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	chrome/browser/resources/script_bubble/16.png	View	1 chunk	+0 lines, -10 lines	0 comments	Download
D	chrome/browser/resources/script_bubble/manifest.json	View	1 chunk	+0 lines, -13 lines	0 comments	Download
D	chrome/browser/resources/script_bubble/popup.html	View	1 chunk	+0 lines, -48 lines	0 comments	Download
D	chrome/browser/resources/script_bubble/popup.js	View	1 chunk	+0 lines, -32 lines	0 comments	Download

Total messages: 3 (0 generated)

Finnur

This is passing locally, but the try servers are freaking out on some missing EOL ...

8 years ago (2012-11-30 23:53:30 UTC) #1

lgtm