Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 11308130: Rename onSuccess to onComplete in HttpRequest. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 5c158bf3673d86b8332664bf69aafa1588b10736..0ec72d8ebb2c1e312f7c1fcf700b4af75a466767 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -9832,11 +9832,13 @@ class HtmlElement extends Element implements Element native "*HTMLHtmlElement" {
class HttpRequest extends EventTarget native "*XMLHttpRequest" {
- factory HttpRequest.get(String url, onSuccess(HttpRequest request)) =>
- _HttpRequestFactoryProvider.createHttpRequest_get(url, onSuccess);
+ factory HttpRequest.get(String url, onComplete(HttpRequest request)) =>
+ _HttpRequestFactoryProvider.createHttpRequest_get(url, onComplete);
- factory HttpRequest.getWithCredentials(String url, onSuccess(HttpRequest request)) =>
- _HttpRequestFactoryProvider.createHttpRequest_getWithCredentials(url, onSuccess);
+ factory HttpRequest.getWithCredentials(String url,
+ onComplete(HttpRequest request)) =>
+ _HttpRequestFactoryProvider.createHttpRequest_getWithCredentials(url,
+ onComplete);
factory HttpRequest() => _HttpRequestFactoryProvider.createHttpRequest();
@@ -21308,12 +21310,12 @@ class _HttpRequestFactoryProvider {
JS('HttpRequest', 'new XMLHttpRequest()');
static HttpRequest createHttpRequest_get(String url,
- onSuccess(HttpRequest request)) =>
- _HttpRequestUtils.get(url, onSuccess, false);
+ onComplete(HttpRequest request)) =>
+ _HttpRequestUtils.get(url, onComplete, false);
static HttpRequest createHttpRequest_getWithCredentials(String url,
- onSuccess(HttpRequest request)) =>
- _HttpRequestUtils.get(url, onSuccess, true);
+ onComplete(HttpRequest request)) =>
+ _HttpRequestUtils.get(url, onComplete, true);
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a

Powered by Google App Engine
This is Rietveld 408576698