Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 11308076: Browser-tests for editing the dictionary on chrome://settings/editDictionary (Closed)

Created:
8 years, 1 month ago by please use gerrit instead
Modified:
8 years, 1 month ago
Reviewers:
csilv
CC:
chromium-reviews, dbeam+watch-options_chromium.org, groby-ooo-7-16, rpetterson
Base URL:
http://git.chromium.org/chromium/src.git@dictionary
Visibility:
Public.

Description

Browser-tests for editing the dictionary on chrome://settings/editDictionary BUG=161361 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168894

Patch Set 1 #

Patch Set 2 : Add class comment #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M chrome/browser/resources/options/language_dictionary_overlay.js View 1 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/options/edit_dictionary_browsertest.js View 1 chunk +53 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
please use gerrit instead
Chris: This is a WebUI test for chrome://settings/editDictionary. The test adds and removes a word ...
8 years, 1 month ago (2012-11-16 19:54:42 UTC) #1
csilv
lgtm
8 years, 1 month ago (2012-11-16 21:52:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/11308076/14001
8 years, 1 month ago (2012-11-20 20:38:09 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-11-20 22:38:19 UTC) #4
Change committed as 168894

Powered by Google App Engine
This is Rietveld 408576698