Issue 11308053: Merge 167819 - Fix crash when programatically closing media gallery dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11308053: Merge 167819 - Fix crash when programatically closing media gallery dialog (Closed)

Created:
8 years, 1 month ago by sail

Modified:
8 years, 1 month ago

Reviewers:
sail

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1312/src/

Visibility:
Public.

Merge 167819 - Fix crash when programatically closing media gallery dialog If the media gallery dialog was closed by something other than clicking "Cancel" or "Ok" then Chrome would crash. The problem was that a bug in the way that I was closing the dialog. I was doing endSheet:alert when I should be doing endSheet:[alert window]. BUG=156537 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/11369253 TBR=sail@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=168043

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -3 lines)			Patch
M	chrome/browser/media_gallery/media_galleries_dialog_controller.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/media_gallery/media_galleries_dialog_controller.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/media_gallery/media_galleries_dialog_controller_mock.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm	View	2 chunks	+3 lines, -1 line	0 comments	Download
A +	chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_browsertest.mm	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	2 chunks	+3 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)