chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_browsertest.mm - Issue 11308053: Merge 167819 - Fix crash when programatically closing media gallery dialog

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_browsertest.mm

Issue 11308053: Merge 167819 - Fix crash when programatically closing media gallery dialog (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1312/src/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm ('k') | chrome/chrome_tests.gypi » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h"	5 #include "chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h"

6	6

7 #include "chrome/browser/media_gallery/media_galleries_dialog_controller_mock.h"	7 #include "chrome/browser/media_gallery/media_galleries_dialog_controller_mock.h"

8 #include "chrome/browser/ui/browser_tabstrip.h"	8 #include "chrome/browser/ui/browser_tabstrip.h"

9 #include "chrome/browser/ui/constrained_window_tab_helper.h"	9 #include "chrome/browser/ui/constrained_window_tab_helper.h"

10 #include "chrome/test/base/in_process_browser_test.h"	10 #include "chrome/test/base/in_process_browser_test.h"

(...skipping 28 matching lines...) Expand all Loading...
39 scoped_nsobject<NSWindow> window([[dialog->alert_ window] retain]);	39 scoped_nsobject<NSWindow> window([[dialog->alert_ window] retain]);

40 EXPECT_TRUE([window isVisible]);	40 EXPECT_TRUE([window isVisible]);

41	41

42 ConstrainedWindowTabHelper* constrained_window_tab_helper =	42 ConstrainedWindowTabHelper* constrained_window_tab_helper =

43 ConstrainedWindowTabHelper::FromWebContents(web_contents);	43 ConstrainedWindowTabHelper::FromWebContents(web_contents);

44 constrained_window_tab_helper->CloseConstrainedWindows();	44 constrained_window_tab_helper->CloseConstrainedWindows();

45 EXPECT_FALSE([window isVisible]);	45 EXPECT_FALSE([window isVisible]);

46 }	46 }

47	47

48 } // namespace chrome	48 } // namespace chrome

OLD	NEW