Gets mandoline working on android

Gets mandoline working on android

This consists of the following pieces:
. html_viewer now uses ResourceProvider to get resources.
. html_viewer no longer directly uses java.
. The java support for mojo_runner/shell has been mode pluggable:
  . You specify the name of the .so to load by way of a meta-tag in
    the manifest. This way mandoline can specify it's own.
  . Android's main function calls to an InitContext() function that
    mandoline plugs in.
  . The apk can include resources to extract. These are listed in the
    file 'assets_list.' The gn template rule
    generate_mojo_shell_assets_list does this for you given a
    directory.
. Changed around scripts to work with both mojo_shell/runner and
  mandoline.

BUG=481698
TEST=covered by tests
R=ben@chromim.org, jcivelli@chromium.org

Committed: https://crrev.com/c55c0a6cab1f3d767318ac8c6fecba8546897dd5
Cr-Commit-Position: refs/heads/master@{#329250}

[sky, 2015-05-11 19:17:12]

sky@chromium.org changed reviewers:
+ ben@chromium.org
- ben@chromim.org

[Jay Civelli, 2015-05-11 21:07:34]

https://codereview.chromium.org/1130763004/diff/40001/components/html_viewer/...
File components/html_viewer/html_viewer.cc (right):

https://codereview.chromium.org/1130763004/diff/40001/components/html_viewer/...
components/html_viewer/html_viewer.cc:190: paths.insert("natives_blob.bin");
Should we use constants for these strings since they appear more than once?

https://codereview.chromium.org/1130763004/diff/40001/mojo/runner/android/apk...
File mojo/runner/android/apk/src/org/chromium/mojo/shell/FileHelper.java
(right):

https://codereview.chromium.org/1130763004/diff/40001/mojo/runner/android/apk...
mojo/runner/android/apk/src/org/chromium/mojo/shell/FileHelper.java:100:
outputFile = new File(outputDirectory.getPath() + File.separator + assetName);
This looks equivalent to what is was before. Do you need that change?

https://codereview.chromium.org/1130763004/diff/40001/mojo/runner/android/apk...
File mojo/runner/android/apk/src/org/chromium/mojo/shell/ShellMain.java (right):

https://codereview.chromium.org/1130763004/diff/40001/mojo/runner/android/apk...
mojo/runner/android/apk/src/org/chromium/mojo/shell/ShellMain.java:56: if
(!line.equals("bootstrap_java.dex.jar") && !line.equals("libbootstrap.so")) {
Should we filter out blank lines just to be on the safe side?

[sky, 2015-05-11 21:13:35]

https://codereview.chromium.org/1130763004/diff/40001/components/html_viewer/...
File components/html_viewer/html_viewer.cc (right):

https://codereview.chromium.org/1130763004/diff/40001/components/html_viewer/...
components/html_viewer/html_viewer.cc:190: paths.insert("natives_blob.bin");
On 2015/05/11 21:07:33, Jay Civelli wrote:
> Should we use constants for these strings since they appear more than once?

Definitely. I'm hoping to do this later (see todo on 185).

https://codereview.chromium.org/1130763004/diff/40001/mojo/runner/android/apk...
File mojo/runner/android/apk/src/org/chromium/mojo/shell/FileHelper.java
(right):

https://codereview.chromium.org/1130763004/diff/40001/mojo/runner/android/apk...
mojo/runner/android/apk/src/org/chromium/mojo/shell/FileHelper.java:100:
outputFile = new File(outputDirectory.getPath() + File.separator + assetName);
On 2015/05/11 21:07:34, Jay Civelli wrote:
> This looks equivalent to what is was before. Do you need that change?

Done.

https://codereview.chromium.org/1130763004/diff/40001/mojo/runner/android/apk...
File mojo/runner/android/apk/src/org/chromium/mojo/shell/ShellMain.java (right):

https://codereview.chromium.org/1130763004/diff/40001/mojo/runner/android/apk...
mojo/runner/android/apk/src/org/chromium/mojo/shell/ShellMain.java:56: if
(!line.equals("bootstrap_java.dex.jar") && !line.equals("libbootstrap.so")) {
On 2015/05/11 21:07:34, Jay Civelli wrote:
> Should we filter out blank lines just to be on the safe side?

Done.

[Jay Civelli, 2015-05-11 21:18:24]

LGTM

https://codereview.chromium.org/1130763004/diff/80001/mojo/runner/android/apk...
File mojo/runner/android/apk/src/org/chromium/mojo/shell/ShellMain.java (right):

https://codereview.chromium.org/1130763004/diff/80001/mojo/runner/android/apk...
mojo/runner/android/apk/src/org/chromium/mojo/shell/ShellMain.java:57: &&
!line.equals("libbootstrap.so")) {
Nit: you may want to call trim() before isEmpty() so pure white-space lines are
skipped not just empty one.

[Ben Goodger (Google), 2015-05-11 21:26:22]

lgtm

https://codereview.chromium.org/1130763004/diff/80001/components/html_viewer/...
File components/html_viewer/BUILD.gn (right):

https://codereview.chromium.org/1130763004/diff/80001/components/html_viewer/...
components/html_viewer/BUILD.gn:181: "$root_out_dir/ui_test.pak",
this seems weird... I know you're just pulling this forward but I'm noticing it
for the first time. Can you add a TODO to not depend on a test resource file
from production code?

[sky, 2015-05-11 21:34:21]

https://codereview.chromium.org/1130763004/diff/80001/components/html_viewer/...
File components/html_viewer/BUILD.gn (right):

https://codereview.chromium.org/1130763004/diff/80001/components/html_viewer/...
components/html_viewer/BUILD.gn:181: "$root_out_dir/ui_test.pak",
On 2015/05/11 21:26:22, Ben Goodger (Google) wrote:
> this seems weird... I know you're just pulling this forward but I'm noticing
it
> for the first time. Can you add a TODO to not depend on a test resource file
> from production code?

Done.

https://codereview.chromium.org/1130763004/diff/80001/mojo/runner/android/apk...
File mojo/runner/android/apk/src/org/chromium/mojo/shell/ShellMain.java (right):

https://codereview.chromium.org/1130763004/diff/80001/mojo/runner/android/apk...
mojo/runner/android/apk/src/org/chromium/mojo/shell/ShellMain.java:57: &&
!line.equals("libbootstrap.so")) {
On 2015/05/11 21:18:24, Jay Civelli wrote:
> Nit: you may want to call trim() before isEmpty() so pure white-space lines
are
> skipped not just empty one.

Done.

[sky, 2015-05-11 21:34:30]

The CQ bit was checked by sky@chromium.org

[sky, 2015-05-11 21:34:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
jcivelli@chromium.org, ben@chromium.org
Link to the patchset: https://codereview.chromium.org/1130763004/#ps100001
(title: "feedback")

[commit-bot: I haz the power, 2015-05-11 21:37:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130763004/100001

[commit-bot: I haz the power, 2015-05-11 22:15:00]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-05-11 22:16:06]

Patchset 6 (id:??) landed as
https://crrev.com/c55c0a6cab1f3d767318ac8c6fecba8546897dd5
Cr-Commit-Position: refs/heads/master@{#329250}