Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3780)

Unified Diff: chrome/browser/ui/webui/ntp/new_tab_page_handler.cc

Issue 1130753007: Start axing NTP4 dead code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/new_tab_page_handler.cc
diff --git a/chrome/browser/ui/webui/ntp/new_tab_page_handler.cc b/chrome/browser/ui/webui/ntp/new_tab_page_handler.cc
index aef4044d2d2ef5a3ca6542f57b31e7c4cba3d927..de548dfa171d4b40208042cb5db85121d52d9277 100644
--- a/chrome/browser/ui/webui/ntp/new_tab_page_handler.cc
+++ b/chrome/browser/ui/webui/ntp/new_tab_page_handler.cc
@@ -155,14 +155,9 @@ void NewTabPageHandler::HandleLogTimeToClick(const base::ListValue* args) {
if (histogram_name == "NewTabPage.TimeToClickMostVisited") {
UMA_HISTOGRAM_LONG_TIMES("NewTabPage.TimeToClickMostVisited", delta);
- } else if (histogram_name == "NewTabPage.TimeToClickRecentlyClosed") {
- UMA_HISTOGRAM_LONG_TIMES("NewTabPage.TimeToClickRecentlyClosed", delta);
} else if (histogram_name == "ExtendedNewTabPage.TimeToClickMostVisited") {
Evan Stade 2015/05/14 19:04:55 then this one can probably be deleted as well
Dan Beam 2015/05/14 19:56:46 there's a lot more code to go. this CL is targete
UMA_HISTOGRAM_LONG_TIMES(
"ExtendedNewTabPage.TimeToClickMostVisited", delta);
- } else if (histogram_name == "ExtendedNewTabPage.TimeToClickRecentlyClosed") {
- UMA_HISTOGRAM_LONG_TIMES(
- "ExtendedNewTabPage.TimeToClickRecentlyClosed", delta);
Evan Stade 2015/05/14 00:09:44 ah! this is one way to verify the code isn't used
Dan Beam 2015/05/14 01:09:34 can't find it in UMA nor is it in histograms.xml
} else {
NOTREACHED();
}

Powered by Google App Engine
This is Rietveld 408576698