Start axing NTP4 dead code.

chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

Index: chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
diff --git a/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc b/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
index 258c8cb9099752d41635312184c2e4f1dce0e6b9..22cfbe9e4db1a43fa784967c55d999d1a588e08e 100644
--- a/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
+++ b/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
@@ -166,8 +166,7 @@ NTPResourceCache::NTPResourceCache(Profile* profile)
     : profile_(profile), is_swipe_tracking_from_scroll_events_enabled_(false),
       should_show_apps_page_(NewTabUI::ShouldShowApps()),
       should_show_most_visited_page_(true),
-      should_show_other_devices_menu_(true),
-      should_show_recently_closed_menu_(true) {
+      should_show_other_devices_menu_(true) {
   registrar_.Add(this, chrome::NOTIFICATION_BROWSER_THEME_CHANGED,
                  content::Source<ThemeService>(
                      ThemeServiceFactory::GetForProfile(profile)));
@@ -418,8 +417,6 @@ void NTPResourceCache::CreateNewTabHTML() {
   load_time_data.SetBoolean("showMostvisited", should_show_most_visited_page_);
   load_time_data.SetBoolean("showAppLauncherPromo",
       ShouldShowAppLauncherPromo());
-  load_time_data.SetBoolean("showRecentlyClosed",
-      should_show_recently_closed_menu_);
   load_time_data.SetString("title",
       l10n_util::GetStringUTF16(IDS_NEW_TAB_TITLE));
   load_time_data.SetString("mostvisited",
@@ -428,16 +425,10 @@ void NTPResourceCache::CreateNewTabHTML() {
       l10n_util::GetStringUTF16(IDS_NEW_TAB_SUGGESTIONS));
   load_time_data.SetString("restoreThumbnailsShort",
       l10n_util::GetStringUTF16(IDS_NEW_TAB_RESTORE_THUMBNAILS_SHORT_LINK));
-  load_time_data.SetString("recentlyclosed",
-      l10n_util::GetStringUTF16(IDS_NEW_TAB_RECENTLY_CLOSED));

[Dan Beam, 2015/05/13 23:18:01]

these are all still used from the flapjacks menu

[Evan Stade, 2015/05/14 00:09:45]

should probably consider renaming them/reorganizing the string file

[Dan Beam, 2015/05/14 01:09:34]

they're all still valid ("1 tab", "## tabs" and "Recently closed" are all still
used and validly named)

[Evan Stade, 2015/05/14 19:04:55]

IDS_NEW_TAB_FOO is the conventional name of a string that is used in the new tab
page, and strings used in the NTP are grouped together in the grd file.

[Dan Beam, 2015/05/14 19:56:46]

ah, the prefix. Done.

   load_time_data.SetString("webStoreTitle",
       l10n_util::GetStringUTF16(IDS_EXTENSION_WEB_STORE_TITLE));
   load_time_data.SetString("webStoreTitleShort",
       l10n_util::GetStringUTF16(IDS_EXTENSION_WEB_STORE_TITLE_SHORT));
-  load_time_data.SetString("closedwindowsingle",
-      l10n_util::GetStringUTF16(IDS_NEW_TAB_RECENTLY_CLOSED_WINDOW_SINGLE));
-  load_time_data.SetString("closedwindowmultiple",
-      l10n_util::GetStringUTF16(IDS_NEW_TAB_RECENTLY_CLOSED_WINDOW_MULTIPLE));

[jungshik at Google, 2015/05/14 08:02:04]

IDS_NEW_TAB_RECENTLY_CLOSED_WINDOW_{SINGLE,MULTIPLE} have to be removed from
generated_resources.grd. My CL added IDS_NEW_TAB_RECENTLY_CLOSED_WINDOW (using
ICU plural syntax) but left the two above alone because this file still uses
them. 

   load_time_data.SetString("attributionintro",
       l10n_util::GetStringUTF16(IDS_NEW_TAB_ATTRIBUTION_INTRO));
   load_time_data.SetString("thumbnailremovednotification",