Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: components/dom_distiller/core/html/dom_distiller_viewer.html

Issue 1130703003: Show template before distiller finishes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ios-superclass
Patch Set: Rebase and add file to gypi Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/core/html/dom_distiller_viewer.html
diff --git a/components/dom_distiller/core/html/dom_distiller_viewer.html b/components/dom_distiller/core/html/dom_distiller_viewer.html
index 2aef5882009b4921a164083f3fbe6b614276e4d4..116eb0fb539c141f1b322302e6c13fbc9ed2dbd2 100644
--- a/components/dom_distiller/core/html/dom_distiller_viewer.html
+++ b/components/dom_distiller/core/html/dom_distiller_viewer.html
@@ -8,11 +8,11 @@ found in the LICENSE file.
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width,initial-scale=1,maximum-scale=1,user-scalable=no">
- <title>$1</title>
- $2
+ <title></title>
cjhopman 2015/05/21 20:53:45 Should we have a title of some sort while loading?
mdjones 2015/05/22 00:44:48 I added a string that just contains "Reader Mode"
+ $1
cjhopman 2015/05/21 20:53:45 nit: could we get comments by these non-obvious pl
mdjones 2015/05/22 00:44:48 Done.
<link href='https://fonts.googleapis.com/css?family=Open+Sans' rel='stylesheet' type='text/css'>
</head>
-<body dir="$8" class="$4">
+<body class="$3">
<div id="contentWrap">
<div id="mainContent">
<article>
@@ -20,7 +20,7 @@ found in the LICENSE file.
<div id="titleCollapse">
<div class="verticalCenterOuter">
<div class="verticalCenterInner">
- <h1 id="titleHolder">$1</h1>
+ <h1 id="titleHolder"></h1>
</div>
</div>
</div>
@@ -28,7 +28,7 @@ found in the LICENSE file.
<div id="content"></div>
</article>
</div>
- <div id="loadingIndicator" class="$5">
+ <div id="loadingIndicator" class="visible">
<div id="loader">
<div class="circle initial">
<span class="mask">
@@ -82,7 +82,7 @@ found in the LICENSE file.
</div>
</div>
<div id="showOriginal">
- <a href="$6">$7</a>
+ <a href="$4">$5</a>
</div>
</div>
<div id="feedbackContainer" class="footerFeedback">
@@ -96,5 +96,5 @@ found in the LICENSE file.
<div class="clear"></div>
</div>
</body>
-$3
+$2
</html>

Powered by Google App Engine
This is Rietveld 408576698