components/dom_distiller/core/html/dom_distiller_viewer.html - Issue 1130703003: Show template before distiller finishes

Side by Side Diff: components/dom_distiller/core/html/dom_distiller_viewer.html

Issue 1130703003: Show template before distiller finishes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ios-superclass

Patch Set: Rebase and add file to gypi Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/dom_distiller/core/dom_distiller_request_view_base.cc ('K') | « components/dom_distiller/core/dom_distiller_request_view_base_unittest.cc ('k') | components/dom_distiller/core/javascript/dom_distiller_viewer.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <!--	2 <!--

3 Copyright 2014 The Chromium Authors. All rights reserved.	3 Copyright 2014 The Chromium Authors. All rights reserved.

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7 <html>	7 <html>

8 <head>	8 <head>

9 <meta charset="utf-8">	9 <meta charset="utf-8">

10 <meta name="viewport" content="width=device-width,initial-scale=1,maximum-scal e=1,user-scalable=no">	10 <meta name="viewport" content="width=device-width,initial-scale=1,maximum-scal e=1,user-scalable=no">

11 <title>$1</title>	11 <title></title>
	cjhopman 2015/05/21 20:53:45 Should we have a title of some sort while loading? Should we have a title of some sort while loading? mdjones 2015/05/22 00:44:48 I added a string that just contains "Reader Mode" Show quoted text On 2015/05/21 20:53:45, cjhopman wrote: > Should we have a title of some sort while loading? I added a string that just contains "Reader Mode" for this title. This could be dynamically put here but I don't think it needs to be. I don't thing we should have anything in the "titleHolder" below.
12 $2	12 $1
	cjhopman 2015/05/21 20:53:45 nit: could we get comments by these non-obvious pl nit: could we get comments by these non-obvious placeholders? mdjones 2015/05/22 00:44:48 Done. Show quoted text On 2015/05/21 20:53:45, cjhopman wrote: > nit: could we get comments by these non-obvious placeholders? Done.
13 <link href='https://fonts.googleapis.com/css?family=Open+Sans' rel='stylesheet ' type='text/css'>	13 <link href='https://fonts.googleapis.com/css?family=Open+Sans' rel='stylesheet ' type='text/css'>

14 </head>	14 </head>

15 <body dir="$8" class="$4">	15 <body class="$3">

16 <div id="contentWrap">	16 <div id="contentWrap">

17 <div id="mainContent">	17 <div id="mainContent">

18 <article>	18 <article>

19 <header id="articleHeader">	19 <header id="articleHeader">

20 <div id="titleCollapse">	20 <div id="titleCollapse">

21 <div class="verticalCenterOuter">	21 <div class="verticalCenterOuter">

22 <div class="verticalCenterInner">	22 <div class="verticalCenterInner">

23 <h1 id="titleHolder">$1</h1>	23 <h1 id="titleHolder"></h1>

24 </div>	24 </div>

25 </div>	25 </div>

26 </div>	26 </div>

27 </header>	27 </header>

28 <div id="content"></div>	28 <div id="content"></div>

29 </article>	29 </article>

30 </div>	30 </div>

31 <div id="loadingIndicator" class="$5">	31 <div id="loadingIndicator" class="visible">

32 <div id="loader">	32 <div id="loader">

33 <div class="circle initial">	33 <div class="circle initial">

34 <span class="mask">	34 <span class="mask">

35 <span class="mover"></span>	35 <span class="mover"></span>

36 </span>	36 </span>

37 </div>	37 </div>

38	38

39 <div class="circle red">	39 <div class="circle red">

40 <span class="mask first">	40 <span class="mask first">

41 <span class="base"></span>	41 <span class="base"></span>

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
75 <span class="mover"></span>	75 <span class="mover"></span>

76 </span>	76 </span>

77 <span class="mask second">	77 <span class="mask second">

78 <span class="base"></span>	78 <span class="base"></span>

79 <span class="mover"></span>	79 <span class="mover"></span>

80 </span>	80 </span>

81 </div>	81 </div>

82 </div>	82 </div>

83 </div>	83 </div>

84 <div id="showOriginal">	84 <div id="showOriginal">

85 <a href="$6">$7</a>	85 <a href="$4">$5</a>

86 </div>	86 </div>

87 </div>	87 </div>

88 <div id="feedbackContainer" class="footerFeedback">	88 <div id="feedbackContainer" class="footerFeedback">

89 <div class="feedbackContent">	89 <div class="feedbackContent">

90 <div id="feedbackQuestion"></div>	90 <div id="feedbackQuestion"></div>

91 <div class="feedbackButtonWrap">	91 <div class="feedbackButtonWrap">

92 <a class="feedbackButton" id="feedbackNo"></a>	92 <a class="feedbackButton" id="feedbackNo"></a>

93 <a class="feedbackButton" id="feedbackYes"></a>	93 <a class="feedbackButton" id="feedbackYes"></a>

94 </div>	94 </div>

95 </div>	95 </div>

96 <div class="clear"></div>	96 <div class="clear"></div>

97 </div>	97 </div>

98 </body>	98 </body>

99 $3	99 $2

100 </html>	100 </html>

OLD	NEW