Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 11307012: Use movw/movt on ARM to load constant roots (Closed)

Created:
8 years, 1 month ago by Jay Conrod
Modified:
8 years, 1 month ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Use movw/movt on ARM to load constant roots BUG=none TEST=none Committed: https://code.google.com/p/v8/source/detail?r=12895

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/heap.h View 1 1 chunk +4 lines, -0 lines 1 comment Download
M src/heap.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
danno
http://codereview.chromium.org/11307012/diff/1/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/11307012/diff/1/src/arm/macro-assembler-arm.cc#newcode427 src/arm/macro-assembler-arm.cc:427: if (root->IsOddball() || root->IsMap() || Can you phrase this ...
8 years, 1 month ago (2012-10-29 15:05:39 UTC) #1
danno
8 years, 1 month ago (2012-11-07 21:51:35 UTC) #2
Thanks for the patch.

LGTM, I will land this after I verify there is no performance regression.

http://codereview.chromium.org/11307012/diff/3001/src/heap.h
File src/heap.h (right):

http://codereview.chromium.org/11307012/diff/3001/src/heap.h#newcode1455
src/heap.h:1455: // they are in new space.
I don't think this comment is correct. The comment about being in new space
isn't accurate, and this patch doesn't check for it. I'll adjust before landing.

Powered by Google App Engine
This is Rietveld 408576698