src/heap.h - Issue 11307012: Use movw/movt on ARM to load constant roots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap.h

Issue 11307012: Use movw/movt on ARM to load constant roots (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap.h

===================================================================

--- src/heap.h (revision 12826)

+++ src/heap.h (working copy)

@@ -1451,6 +1451,10 @@

STATIC_CHECK(kFalseValueRootIndex == Internals::kFalseValueRootIndex);

STATIC_CHECK(kempty_symbolRootIndex == Internals::kEmptySymbolRootIndex);

+ // Generated code can embed direct references to non-writable roots if

+ // they are in new space.

danno 2012/11/07 21:51:36 I don't think this comment is correct. The comment

+ static bool RootCanBeWrittenAfterInitialization(RootListIndex root_index);

MUST_USE_RESULT MaybeObject* NumberToString(

Object* number, bool check_number_string_cache = true);

MUST_USE_RESULT MaybeObject* Uint32ToString(

« no previous file with comments | « src/arm/macro-assembler-arm.cc ('k') | src/heap.cc » ('j') | no next file with comments »