DescriptionNix Windows-specific textfield move-by-word behavior; enable tests.
Use the existing code for Linux and Chrome OS on Windows too.
It's more well tested and doesn't suffer from known RTL defects.
We originally intended to mimic platform-specific nuances.
The current Win-specific code does not seem worth keeping:
1) It suffers from a long-standing RTL left/right reversal defect.
2) It lacks automated testing (existing tests were disabled on Windows).
3) It doesn't match Windows perfectly: <http://crbug.com/196326#c5>
4) The benefits of copying quicks are dubious: <http://crbug.com/196326#c6>
We can invest in matching Windows behavior correctly later, if that's desirable.
The HarfBuzz code was added in https://codereview.chromium.org/421053002
It was based off of the corresponding Pango code at the time:
https://chromium.googlesource.com/chromium/src/+/925fea1e3bece4b2e8909c5731cc4874a8cab80d/ui/gfx/render_text_pango.cc
TEST=Cursor move-by-word on Windows Omnibox, etc. works well.
BUG=486485, 196326
R=asvitkine@chromium.org
Patch Set 1 #
Messages
Total messages: 13 (5 generated)
|