Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 421053002: Enable RenderTextHarfBuzz by default (Closed)

Created:
6 years, 4 months ago by ckocagil
Modified:
6 years, 4 months ago
Reviewers:
msw
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Enable RenderTextHarfBuzz by default BUG=321868 TBR=msw Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288588

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M ui/gfx/render_text.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/render_text.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/render_text_harfbuzz.cc View 1 3 chunks +16 lines, -2 lines 0 comments Download
M ui/gfx/render_text_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
ckocagil
The CQ bit was checked by ckocagil@chromium.org
6 years, 4 months ago (2014-07-27 05:23:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckocagil@chromium.org/421053002/1
6 years, 4 months ago (2014-07-27 05:23:27 UTC) #2
msw
lgtm, but there appear to be some legit test failures.
6 years, 4 months ago (2014-07-27 07:02:05 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-27 08:58:56 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-27 09:26:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/278)
6 years, 4 months ago (2014-07-27 09:26:27 UTC) #6
ckocagil
Mike, I don't locally have a Mac, do you think you can take a look ...
6 years, 4 months ago (2014-08-07 13:03:37 UTC) #7
msw
On 2014/08/07 13:03:37, ckocagil wrote: > Mike, I don't locally have a Mac, do you ...
6 years, 4 months ago (2014-08-07 17:02:41 UTC) #8
ckocagil
On 2014/08/07 17:02:41, msw wrote: > On 2014/08/07 13:03:37, ckocagil wrote: > > Mike, I ...
6 years, 4 months ago (2014-08-09 16:30:17 UTC) #9
ckocagil
The CQ bit was checked by ckocagil@chromium.org
6 years, 4 months ago (2014-08-09 16:30:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckocagil@chromium.org/421053002/20001
6 years, 4 months ago (2014-08-09 16:31:21 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 18:04:15 UTC) #12
Message was sent while issue was closed.
Change committed as 288588

Powered by Google App Engine
This is Rietveld 408576698