Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1130683004: Deflake WidgetInputMethodInteractiveTest.TwoTopWindows on Linux (Closed)

Created:
5 years, 7 months ago by tapted
Modified:
5 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deflake WidgetInputMethodInteractiveTest.TwoTopWindows on Linux I was able to repro the flake with ~1% probability and traced. It was flaky because earlier window server messages were still pending when the test started running checks. So the first `ActivateSync` would actually break out of the message loop wait too soon. BUG=484836 Committed: https://crrev.com/5f19016c6780aba48125ce089f00c9f0b98e8e92 Cr-Commit-Position: refs/heads/master@{#329267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M ui/views/widget/widget_interactive_uitest.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
Hi sadrul, please take a look
5 years, 7 months ago (2015-05-11 06:38:46 UTC) #2
sadrul
lgtm
5 years, 7 months ago (2015-05-11 13:51:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130683004/1
5 years, 7 months ago (2015-05-11 23:04:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 23:12:03 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 23:13:42 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f19016c6780aba48125ce089f00c9f0b98e8e92
Cr-Commit-Position: refs/heads/master@{#329267}

Powered by Google App Engine
This is Rietveld 408576698