Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1512)

Unified Diff: ui/views/widget/widget_interactive_uitest.cc

Issue 1130683004: Deflake WidgetInputMethodInteractiveTest.TwoTopWindows on Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/widget_interactive_uitest.cc
diff --git a/ui/views/widget/widget_interactive_uitest.cc b/ui/views/widget/widget_interactive_uitest.cc
index f9d660535a339fba569d19d701a6146163ce757c..5c2777354ea3912afa1dec71e8aa4518fc9e1ea4 100644
--- a/ui/views/widget/widget_interactive_uitest.cc
+++ b/ui/views/widget/widget_interactive_uitest.cc
@@ -1582,8 +1582,7 @@ TEST_F(WidgetInputMethodInteractiveTest, TwoWindows) {
// Test input method focus changes affected by focus changes cross 2 top
// windows.
-// Flaky: https://crbug.com/484836
-TEST_F(WidgetInputMethodInteractiveTest, DISABLED_TwoTopWindows) {
+TEST_F(WidgetInputMethodInteractiveTest, TwoTopWindows) {
Widget* widget1 = CreateWidget();
Widget* widget2 = CreateWidget();
Textfield* textfield1 = new Textfield;
@@ -1591,8 +1590,11 @@ TEST_F(WidgetInputMethodInteractiveTest, DISABLED_TwoTopWindows) {
textfield2->SetTextInputType(ui::TEXT_INPUT_TYPE_PASSWORD);
widget1->GetRootView()->AddChildView(textfield1);
widget2->GetRootView()->AddChildView(textfield2);
- widget1->Show();
- widget2->Show();
+
+ // Do the initial shows synchronously. Otherwise, on X11, the window server
+ // messages may be interleaved with the activation requests below.
+ ShowSync(widget1);
+ ShowSync(widget2);
textfield1->RequestFocus();
textfield2->RequestFocus();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698