chrome/browser/ui/app_list/app_list_syncable_service.cc - Issue 1130353010: Remove deprecated ExtensionService::GetInstalledExtension() usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/app_list_syncable_service.cc

Issue 1130353010: Remove deprecated ExtensionService::GetInstalledExtension() usage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed if to iff Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc ('k') | chrome/browser/ui/app_list/extension_app_item.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/app_list_syncable_service.cc

diff --git a/chrome/browser/ui/app_list/app_list_syncable_service.cc b/chrome/browser/ui/app_list/app_list_syncable_service.cc

index 0932d2cfa7a82b8ae2a448c170f8597bc6515760..b3bc8067107d5bf9286c080ad77da7c9f31c8041 100644

--- a/chrome/browser/ui/app_list/app_list_syncable_service.cc

+++ b/chrome/browser/ui/app_list/app_list_syncable_service.cc

@@ -121,11 +121,9 @@ bool IsUnRemovableDefaultApp(const std::string& id) {

}

void UninstallExtension(ExtensionService* service, const std::string& id) {

- if (service && service->GetInstalledExtension(id)) {

- service->UninstallExtension(id,

- extensions::UNINSTALL_REASON_SYNC,

- base::Bind(&base::DoNothing),

- NULL);

+ if (service) {

+ ExtensionService::UninstallExtensionHelper(

+ service, id, extensions::UNINSTALL_REASON_SYNC);

}