chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc - Issue 1130353010: Remove deprecated ExtensionService::GetInstalledExtension() usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc

Issue 1130353010: Remove deprecated ExtensionService::GetInstalledExtension() usage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed if to iff Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/app_list_controller_delegate.cc ('k') | chrome/browser/ui/app_list/app_list_syncable_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc

diff --git a/chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc b/chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc

index 61b45420fc959952f8bdbb76dc1fd274658122ab..4733461f71a879777e3b7ff254e6c1f65afb8dfd 100644

--- a/chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc

+++ b/chrome/browser/ui/app_list/app_list_controller_delegate_impl.cc

@@ -5,7 +5,6 @@

#include "chrome/browser/ui/app_list/app_list_controller_delegate_impl.h"

#include "chrome/browser/browser_process.h"

-#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/profiles/profile_manager.h"

#include "chrome/browser/ui/app_list/app_list_service_impl.h"

#include "chrome/browser/ui/browser_commands.h"

@@ -14,7 +13,7 @@

#include "chrome/browser/ui/extensions/app_launch_params.h"

#include "chrome/browser/ui/extensions/application_launch.h"

#include "chrome/common/extensions/manifest_handlers/app_launch_info.h"

-#include "extensions/browser/extension_system.h"

+#include "extensions/browser/extension_registry.h"

#include "extensions/common/constants.h"

#include "extensions/common/extension.h"

#include "net/base/url_util.h"

@@ -64,10 +63,9 @@ void AppListControllerDelegateImpl::DoCreateShortcutsFlow(

Profile* profile,

const std::string& extension_id) {

DCHECK(CanDoCreateShortcutsFlow());

- ExtensionService* service =

- extensions::ExtensionSystem::Get(profile)->extension_service();

- DCHECK(service);

- const extensions::Extension* extension = service->GetInstalledExtension(

+ extensions::ExtensionRegistry* registry =

+ extensions::ExtensionRegistry::Get(profile);

+ const extensions::Extension* extension = registry->GetInstalledExtension(

extension_id);

DCHECK(extension);