Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2244)

Unified Diff: content/browser/loader/resource_request_info_impl.cc

Issue 1130343006: Don't share ResourceDispatcherHostImpl's timer for reporting upload progress. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@safari-backend
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_request_info_impl.cc
diff --git a/content/browser/loader/resource_request_info_impl.cc b/content/browser/loader/resource_request_info_impl.cc
index be8ffa0ead4395e41906ad70e172b029d5f8f10d..6f2107183edb4c1ea19f21ead32e8f37beea6aa8 100644
--- a/content/browser/loader/resource_request_info_impl.cc
+++ b/content/browser/loader/resource_request_info_impl.cc
@@ -60,7 +60,7 @@ void ResourceRequestInfo::AllocateForTesting(net::URLRequest* request,
allow_download, // allow_download
false, // has_user_gesture
false, // enable load timing
- false, // enable upload progress
+ true, // enable upload progress
Andre 2015/05/20 21:05:12 Seems like we would need to plumb this in as an ad
mmenke 2015/05/20 21:15:04 You're right. That method makes me sad.
Andre 2015/05/20 22:36:10 Actually, I think I can just use request->has_uplo
false, // do_not_prompt_for_login
blink::WebReferrerPolicyDefault, // referrer_policy
blink::WebPageVisibilityStateVisible, // visibility_state

Powered by Google App Engine
This is Rietveld 408576698