Chromium Code Reviews Chromium Code Reviews
Issue 1130343006:
Don't share ResourceDispatcherHostImpl's timer for reporting upload progress. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@safari-backend| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "content/browser/loader/resource_request_info_impl.h" | 5 #include "content/browser/loader/resource_request_info_impl.h" |
| 6 | 6 |
| 7 #include "content/browser/loader/global_routing_id.h" | 7 #include "content/browser/loader/global_routing_id.h" |
| 8 #include "content/browser/loader/resource_message_filter.h" | 8 #include "content/browser/loader/resource_message_filter.h" |
| 9 #include "content/common/net/url_request_user_data.h" | 9 #include "content/common/net/url_request_user_data.h" |
| 10 #include "content/public/browser/global_request_id.h" | 10 #include "content/public/browser/global_request_id.h" |
| (...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 53 parent_is_main_frame, // parent_is_main_frame | 53 parent_is_main_frame, // parent_is_main_frame |
| 54 0, // parent_render_frame_id | 54 0, // parent_render_frame_id |
| 55 resource_type, // resource_type | 55 resource_type, // resource_type |
| 56 ui::PAGE_TRANSITION_LINK, // transition_type | 56 ui::PAGE_TRANSITION_LINK, // transition_type |
| 57 false, // should_replace_current_entry | 57 false, // should_replace_current_entry |
| 58 false, // is_download | 58 false, // is_download |
| 59 false, // is_stream | 59 false, // is_stream |
| 60 allow_download, // allow_download | 60 allow_download, // allow_download |
| 61 false, // has_user_gesture | 61 false, // has_user_gesture |
| 62 false, // enable load timing | 62 false, // enable load timing |
| 63 false, // enable upload progress | 63 true, // enable upload progress |
|
Andre
2015/05/20 21:05:12
Seems like we would need to plumb this in as an ad
mmenke
2015/05/20 21:15:04
You're right. That method makes me sad.
Andre
2015/05/20 22:36:10
Actually, I think I can just use request->has_uplo
| |
| 64 false, // do_not_prompt_for_login | 64 false, // do_not_prompt_for_login |
| 65 blink::WebReferrerPolicyDefault, // referrer_policy | 65 blink::WebReferrerPolicyDefault, // referrer_policy |
| 66 blink::WebPageVisibilityStateVisible, // visibility_state | 66 blink::WebPageVisibilityStateVisible, // visibility_state |
| 67 context, // context | 67 context, // context |
| 68 base::WeakPtr<ResourceMessageFilter>(), // filter | 68 base::WeakPtr<ResourceMessageFilter>(), // filter |
| 69 is_async); // is_async | 69 is_async); // is_async |
| 70 info->AssociateWithRequest(request); | 70 info->AssociateWithRequest(request); |
| 71 } | 71 } |
| 72 | 72 |
| 73 // static | 73 // static |
| (...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 272 base::WeakPtr<ResourceMessageFilter> filter) { | 272 base::WeakPtr<ResourceMessageFilter> filter) { |
| 273 child_id_ = child_id; | 273 child_id_ = child_id; |
| 274 route_id_ = route_id; | 274 route_id_ = route_id; |
| 275 origin_pid_ = origin_pid; | 275 origin_pid_ = origin_pid; |
| 276 request_id_ = request_id; | 276 request_id_ = request_id; |
| 277 parent_render_frame_id_ = parent_render_frame_id; | 277 parent_render_frame_id_ = parent_render_frame_id; |
| 278 filter_ = filter; | 278 filter_ = filter; |
| 279 } | 279 } |
| 280 | 280 |
| 281 } // namespace content | 281 } // namespace content |
| OLD | NEW |
