|
Revert of Sketch splitting SkPicture into an interface and SkBigPicture. (patchset #22 id:420001 of https://codereview.chromium.org/1112523006/)
Reason for revert:
speculative revert to fix failures in DEPS roll
Original issue's description:
> Sketch splitting SkPicture into an interface and SkBigPicture.
>
> Adds small pictures for drawRect(), drawTextBlob(), and drawPath().
> These cover about 89% of draw calls from Blink SKPs,
> and about 25% of draw calls from our GMs.
>
> SkPicture handles:
> - serialization and deserialization
> - unique IDs
>
> Everything else is left to the subclasses:
> - playback(), cullRect()
> - hasBitmap(), hasText(), suitableForGPU(), etc.
> - LayerInfo / AccelData if applicable.
>
> The time to record a 1-op picture improves a good chunk
> (2 mallocs to 1), and the time to record a 0-op picture
> greatly improves (2 mallocs to none):
>
> picture_overhead_draw: 450ns -> 350ns
> picture_overhead_nodraw: 300ns -> 90ns
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/c92c129ff85b05a714bd1bf921c02d5e14651f8b
TBR=reed@google.com,robertphillips@google.com,mtklein@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/b7ed856fadae52401d3bbcac22cfc3391780ace8
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+787 lines, -854 lines) |
Patch |
|
M |
gyp/core.gypi
|
View
|
|
3 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
gyp/utils.gypi
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
include/core/SkPicture.h
|
View
|
|
8 chunks |
+170 lines, -52 lines |
0 comments
|
Download
|
|
M |
include/core/SkPictureRecorder.h
|
View
|
|
2 chunks |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
include/utils/SkPictureUtils.h
|
View
|
|
2 chunks |
+1 line, -5 lines |
0 comments
|
Download
|
|
D |
src/core/SkBigPicture.h
|
View
|
|
1 chunk |
+0 lines, -89 lines |
0 comments
|
Download
|
|
D |
src/core/SkBigPicture.cpp
|
View
|
|
1 chunk |
+0 lines, -167 lines |
0 comments
|
Download
|
|
M |
src/core/SkLayerInfo.h
|
View
|
|
4 chunks |
+11 lines, -7 lines |
0 comments
|
Download
|
|
A |
src/core/SkLayerInfo.cpp
|
View
|
|
1 chunk |
+15 lines, -0 lines |
0 comments
|
Download
|
|
D |
src/core/SkMiniRecorder.h
|
View
|
|
1 chunk |
+0 lines, -44 lines |
0 comments
|
Download
|
|
D |
src/core/SkMiniRecorder.cpp
|
View
|
|
1 chunk |
+0 lines, -103 lines |
0 comments
|
Download
|
|
M |
src/core/SkPicture.cpp
|
View
|
|
2 chunks |
+445 lines, -153 lines |
0 comments
|
Download
|
|
D |
src/core/SkPictureCommon.h
|
View
|
|
1 chunk |
+0 lines, -70 lines |
0 comments
|
Download
|
|
M |
src/core/SkPictureRecorder.cpp
|
View
|
|
8 chunks |
+24 lines, -31 lines |
0 comments
|
Download
|
|
M |
src/core/SkRecordDraw.h
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
|
M |
src/core/SkRecordDraw.cpp
|
View
|
|
4 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
|
M |
src/core/SkRecorder.h
|
View
|
|
5 chunks |
+4 lines, -10 lines |
0 comments
|
Download
|
|
M |
src/core/SkRecorder.cpp
|
View
|
|
9 chunks |
+10 lines, -30 lines |
0 comments
|
Download
|
|
M |
src/core/SkRecords.h
|
View
|
|
12 chunks |
+0 lines, -12 lines |
0 comments
|
Download
|
|
M |
src/gpu/GrLayerHoister.cpp
|
View
|
|
9 chunks |
+19 lines, -23 lines |
0 comments
|
Download
|
|
M |
src/gpu/GrRecordReplaceDraw.cpp
|
View
|
|
8 chunks |
+18 lines, -29 lines |
0 comments
|
Download
|
|
M |
src/gpu/SkGpuDevice.h
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/gpu/SkGpuDevice.cpp
|
View
|
|
1 chunk |
+3 lines, -4 lines |
0 comments
|
Download
|
|
A |
src/utils/SkPictureUtils.cpp
|
View
|
|
1 chunk |
+25 lines, -0 lines |
0 comments
|
Download
|
|
M |
tests/GpuLayerCacheTest.cpp
|
View
|
|
1 chunk |
+1 line, -4 lines |
0 comments
|
Download
|
|
M |
tests/PictureTest.cpp
|
View
|
|
4 chunks |
+29 lines, -8 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|