Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1130333002: Revert of Sketch splitting SkPicture into an interface and SkBigPicture. (Closed)

Created:
5 years, 7 months ago by reed2
Modified:
5 years, 7 months ago
CC:
reviews_skia.org, jbroman
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Sketch splitting SkPicture into an interface and SkBigPicture. (patchset #22 id:420001 of https://codereview.chromium.org/1112523006/) Reason for revert: speculative revert to fix failures in DEPS roll Original issue's description: > Sketch splitting SkPicture into an interface and SkBigPicture. > > Adds small pictures for drawRect(), drawTextBlob(), and drawPath(). > These cover about 89% of draw calls from Blink SKPs, > and about 25% of draw calls from our GMs. > > SkPicture handles: > - serialization and deserialization > - unique IDs > > Everything else is left to the subclasses: > - playback(), cullRect() > - hasBitmap(), hasText(), suitableForGPU(), etc. > - LayerInfo / AccelData if applicable. > > The time to record a 1-op picture improves a good chunk > (2 mallocs to 1), and the time to record a 0-op picture > greatly improves (2 mallocs to none): > > picture_overhead_draw: 450ns -> 350ns > picture_overhead_nodraw: 300ns -> 90ns > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/c92c129ff85b05a714bd1bf921c02d5e14651f8b TBR=reed@google.com,robertphillips@google.com,mtklein@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/b7ed856fadae52401d3bbcac22cfc3391780ace8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+787 lines, -854 lines) Patch
M gyp/core.gypi View 3 chunks +1 line, -2 lines 0 comments Download
M gyp/utils.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkPicture.h View 8 chunks +170 lines, -52 lines 0 comments Download
M include/core/SkPictureRecorder.h View 2 chunks +0 lines, -2 lines 0 comments Download
M include/utils/SkPictureUtils.h View 2 chunks +1 line, -5 lines 0 comments Download
D src/core/SkBigPicture.h View 1 chunk +0 lines, -89 lines 0 comments Download
D src/core/SkBigPicture.cpp View 1 chunk +0 lines, -167 lines 0 comments Download
M src/core/SkLayerInfo.h View 4 chunks +11 lines, -7 lines 0 comments Download
A src/core/SkLayerInfo.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
D src/core/SkMiniRecorder.h View 1 chunk +0 lines, -44 lines 0 comments Download
D src/core/SkMiniRecorder.cpp View 1 chunk +0 lines, -103 lines 0 comments Download
M src/core/SkPicture.cpp View 2 chunks +445 lines, -153 lines 0 comments Download
D src/core/SkPictureCommon.h View 1 chunk +0 lines, -70 lines 0 comments Download
M src/core/SkPictureRecorder.cpp View 8 chunks +24 lines, -31 lines 0 comments Download
M src/core/SkRecordDraw.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M src/core/SkRecorder.h View 5 chunks +4 lines, -10 lines 0 comments Download
M src/core/SkRecorder.cpp View 9 chunks +10 lines, -30 lines 0 comments Download
M src/core/SkRecords.h View 12 chunks +0 lines, -12 lines 0 comments Download
M src/gpu/GrLayerHoister.cpp View 9 chunks +19 lines, -23 lines 0 comments Download
M src/gpu/GrRecordReplaceDraw.cpp View 8 chunks +18 lines, -29 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
A src/utils/SkPictureUtils.cpp View 1 chunk +25 lines, -0 lines 0 comments Download
M tests/GpuLayerCacheTest.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M tests/PictureTest.cpp View 4 chunks +29 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
reed2
Created Revert of Sketch splitting SkPicture into an interface and SkBigPicture.
5 years, 7 months ago (2015-05-08 00:29:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130333002/1
5 years, 7 months ago (2015-05-08 00:29:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/b7ed856fadae52401d3bbcac22cfc3391780ace8
5 years, 7 months ago (2015-05-08 00:30:18 UTC) #3
reed2
5 years, 7 months ago (2015-05-08 00:31:12 UTC) #4
Message was sent while issue was closed.
@@@STEP_LOG_LINE@RecordingSourceTest_1.NoDiscardablePixelRefs@RecordingSource...
(run #1):@@@
@@@STEP_LOG_LINE@RecordingSourceTest_1.NoDiscardablePixelRefs@[ RUN      ]
RecordingSourceTest/1.NoDiscardablePixelRefs@@@
@@@STEP_LOG_LINE@RecordingSourceTest_1.NoDiscardablePixelRefs@[3223:3223:0507/165908:3541814002:INFO:SkMiniRecorder.cpp(53)]
../../third_party/skia/src/core/SkMiniRecorder.cpp:53: failed assertion
"false"@@@
@@@STEP_LOG_LINE@RecordingSourceTest_1.NoDiscardablePixelRefs@@@@
@@@STEP_LOG_LINE@RecordingSourceTest_1.NoDiscardablePixelRefs@[3223:3223:0507/165908:3541814140:FATAL:SkMiniRecorder.cpp(53)]
SK_CRASH@@@

Powered by Google App Engine
This is Rietveld 408576698