src/x64/lithium-codegen-x64.cc - Issue 1130283002: [strong] Disallow implicit conversions for comparison

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 1130283002: [strong] Disallow implicit conversions for comparison (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: cl feedback Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/lithium-codegen-x64.cc

diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc

index e030826292ac1b60f1f9b360d045164bab5b1215..f3c006fa1b4c834660a407f69251483c807d7aeb 100644

--- a/src/x64/lithium-codegen-x64.cc

+++ b/src/x64/lithium-codegen-x64.cc

@@ -2548,7 +2548,7 @@ void LCodeGen::DoStringCompareAndBranch(LStringCompareAndBranch* instr) {

DCHECK(ToRegister(instr->context()).is(rsi));

Token::Value op = instr->op();

- Handle<Code> ic = CodeFactory::CompareIC(isolate(), op).code();

+ Handle<Code> ic = CodeFactory::CompareIC(isolate(), op, SLOPPY).code();

CallCode(ic, RelocInfo::CODE_TARGET, instr);

Condition condition = TokenToCondition(op, false);

@@ -2832,7 +2832,8 @@ void LCodeGen::DoCmpT(LCmpT* instr) {

DCHECK(ToRegister(instr->context()).is(rsi));

Token::Value op = instr->op();

- Handle<Code> ic = CodeFactory::CompareIC(isolate(), op).code();

+ Handle<Code> ic =

+ CodeFactory::CompareIC(isolate(), op, instr->language_mode()).code();

CallCode(ic, RelocInfo::CODE_TARGET, instr);

Condition condition = TokenToCondition(op, false);

« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | src/x64/lithium-x64.h » ('j') | no next file with comments »