Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1130183002: Skip test-heap/NoWeakHashTableLeakWithIncrementalMarking for no-snap builds. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Skip test-heap/NoWeakHashTableLeakWithIncrementalMarking for no-snap builds. TBR=machenbach@chromium.org NOTREECHECKS=true Committed: https://crrev.com/976b6b2ce5f97e536dd979745ca5586e5c240a57 Cr-Commit-Position: refs/heads/master@{#28293}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M test/cctest/test-heap.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Yang
5 years, 7 months ago (2015-05-07 09:41:36 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130183002/1
5 years, 7 months ago (2015-05-07 09:42:10 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/179)
5 years, 7 months ago (2015-05-07 09:45:46 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130183002/20001
5 years, 7 months ago (2015-05-07 09:47:03 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-07 10:08:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130183002/20001
5 years, 7 months ago (2015-05-07 10:24:10 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-07 10:25:42 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/976b6b2ce5f97e536dd979745ca5586e5c240a57 Cr-Commit-Position: refs/heads/master@{#28293}
5 years, 7 months ago (2015-05-07 10:25:55 UTC) #13
Michael Achenbach
5 years, 7 months ago (2015-05-07 10:59:59 UTC) #14
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698