Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: test/cctest/test-heap.cc

Issue 1130183002: Skip test-heap/NoWeakHashTableLeakWithIncrementalMarking for no-snap builds. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-heap.cc
diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc
index e4f2f2bf86561cfa3985791d5104e52a9cad9040..ad9fe8ac86644093f24b94e88149dd4e9b33f6d1 100644
--- a/test/cctest/test-heap.cc
+++ b/test/cctest/test-heap.cc
@@ -37,6 +37,7 @@
#include "src/global-handles.h"
#include "src/ic/ic.h"
#include "src/macro-assembler.h"
+#include "src/snapshot/snapshot.h"
#include "test/cctest/cctest.h"
using namespace v8::internal;
@@ -4341,6 +4342,10 @@ TEST(NoWeakHashTableLeakWithIncrementalMarking) {
i::FLAG_retain_maps_for_n_gc = 0;
CcTest::InitializeVM();
Isolate* isolate = CcTest::i_isolate();
+
+ // Do not run for no-snap builds.
+ if (!i::Snapshot::HaveASnapshotToStartFrom(isolate)) return;
+
v8::internal::Heap* heap = CcTest::heap();
// Get a clean slate regarding optimized functions on the heap.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698