Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1130133003: Migrate error messages, part 12. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@messages_11
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Migrate error messages, part 12. Committed: https://crrev.com/fc65e55116cc7b53841294971617ffe8dbec504c Cr-Commit-Position: refs/heads/master@{#28439}

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comment #

Patch Set 3 : fix #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+559 lines, -538 lines) Patch
M src/api.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ast-value-factory.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M src/debug.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/factory.h View 2 chunks +9 lines, -9 lines 0 comments Download
M src/factory.cc View 1 chunk +13 lines, -16 lines 0 comments Download
M src/isolate.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/messages.h View 5 chunks +143 lines, -26 lines 0 comments Download
M src/messages.cc View 5 chunks +47 lines, -45 lines 0 comments Download
M src/messages.js View 1 2 3 5 chunks +9 lines, -150 lines 0 comments Download
M src/objects.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/parser.h View 1 chunk +15 lines, -12 lines 0 comments Download
M src/parser.cc View 42 chunks +84 lines, -72 lines 0 comments Download
M src/pattern-rewriter.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/pending-compilation-error-handler.h View 5 chunks +8 lines, -5 lines 0 comments Download
M src/pending-compilation-error-handler.cc View 1 chunk +9 lines, -11 lines 0 comments Download
M src/preparse-data.h View 7 chunks +6 lines, -8 lines 0 comments Download
M src/preparse-data.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/preparse-data-format.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/preparser.h View 51 chunks +140 lines, -108 lines 0 comments Download
M src/preparser.cc View 18 chunks +35 lines, -25 lines 0 comments Download
M src/scopes.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/scopes.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +9 lines, -25 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Yang
This depends on https://codereview.chromium.org/1140053002/
5 years, 7 months ago (2015-05-15 11:42:01 UTC) #2
mvstanton
lgtm https://codereview.chromium.org/1130133003/diff/1/test/mjsunit/regexp.js File test/mjsunit/regexp.js (right): https://codereview.chromium.org/1130133003/diff/1/test/mjsunit/regexp.js#newcode427 test/mjsunit/regexp.js:427: print(e); nit: is the print needed?
5 years, 7 months ago (2015-05-18 06:17:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130133003/20001
5 years, 7 months ago (2015-05-18 07:03:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/429)
5 years, 7 months ago (2015-05-18 07:18:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130133003/60001
5 years, 7 months ago (2015-05-18 07:54:37 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-18 08:34:13 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:04:06 UTC) #13
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/fc65e55116cc7b53841294971617ffe8dbec504c
Cr-Commit-Position: refs/heads/master@{#28439}

Powered by Google App Engine
This is Rietveld 408576698