Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: src/debug.cc

Issue 1130133003: Migrate error messages, part 12. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@messages_11
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ast-value-factory.h ('k') | src/factory.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/arguments.h" 8 #include "src/arguments.h"
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 651 matching lines...) Expand 10 before | Expand all | Expand 10 after
662 MaybeHandle<Object> maybe_exception; 662 MaybeHandle<Object> maybe_exception;
663 MaybeHandle<Object> result = Execution::TryCall( 663 MaybeHandle<Object> result = Execution::TryCall(
664 function, handle(context->global_proxy()), 0, NULL, &maybe_exception); 664 function, handle(context->global_proxy()), 0, NULL, &maybe_exception);
665 665
666 // Check for caught exceptions. 666 // Check for caught exceptions.
667 if (result.is_null()) { 667 if (result.is_null()) {
668 DCHECK(!isolate->has_pending_exception()); 668 DCHECK(!isolate->has_pending_exception());
669 MessageLocation computed_location; 669 MessageLocation computed_location;
670 isolate->ComputeLocation(&computed_location); 670 isolate->ComputeLocation(&computed_location);
671 Handle<Object> message = MessageHandler::MakeMessageObject( 671 Handle<Object> message = MessageHandler::MakeMessageObject(
672 isolate, "error_loading_debugger", &computed_location, 672 isolate, MessageTemplate::kDebuggerLoading, &computed_location,
673 Vector<Handle<Object> >::empty(), Handle<JSArray>()); 673 isolate->factory()->undefined_value(), Handle<JSArray>());
674 DCHECK(!isolate->has_pending_exception()); 674 DCHECK(!isolate->has_pending_exception());
675 Handle<Object> exception; 675 Handle<Object> exception;
676 if (maybe_exception.ToHandle(&exception)) { 676 if (maybe_exception.ToHandle(&exception)) {
677 isolate->set_pending_exception(*exception); 677 isolate->set_pending_exception(*exception);
678 MessageHandler::ReportMessage(isolate, NULL, message); 678 MessageHandler::ReportMessage(isolate, NULL, message);
679 isolate->clear_pending_exception(); 679 isolate->clear_pending_exception();
680 } 680 }
681 return false; 681 return false;
682 } 682 }
683 683
(...skipping 2716 matching lines...) Expand 10 before | Expand all | Expand 10 after
3400 logger_->DebugEvent("Put", message.text()); 3400 logger_->DebugEvent("Put", message.text());
3401 } 3401 }
3402 3402
3403 3403
3404 void LockingCommandMessageQueue::Clear() { 3404 void LockingCommandMessageQueue::Clear() {
3405 base::LockGuard<base::Mutex> lock_guard(&mutex_); 3405 base::LockGuard<base::Mutex> lock_guard(&mutex_);
3406 queue_.Clear(); 3406 queue_.Clear();
3407 } 3407 }
3408 3408
3409 } } // namespace v8::internal 3409 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ast-value-factory.h ('k') | src/factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698