Chromium Code Reviews

Unified Diff: Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp

Issue 1130113003: Oilpan: remove explicit conversion of getNamedItems()' result, not needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp b/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp
index 32b80271c1e72153a8b29f681362562616dc0c4c..2687607f02a91fe98cb3e36beb18b31aa1535ef0 100644
--- a/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp
@@ -54,16 +54,7 @@ static v8::Local<v8::Value> getNamedItems(HTMLAllCollection* collection, AtomicS
// FIXME: HTML5 specification says this should be a HTMLCollection.
// http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#htmlallcollection
- //
- // FIXME: Oilpan: explicitly convert adopt()'s result so as to
- // disambiguate the (implicit) conversion of its
- // PassRefPtrWillBeRawPtr<StaticElementList> result -- the
- // other toV8() overload that introduces the ambiguity is
- // toV8(NodeList*, ...).
- //
- // When adopt() no longer uses transition types, the conversion
- // can be removed.
- return toV8(PassRefPtrWillBeRawPtr<NodeList>(StaticElementList::adopt(namedItems)), info.Holder(), info.GetIsolate());
+ return toV8(StaticElementList::adopt(namedItems), info.Holder(), info.GetIsolate());
}
template<class CallbackInfo>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine