Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: Source/bindings/core/v8/custom/V8HTMLAllCollectionCustom.cpp

Issue 1130113003: Oilpan: remove explicit conversion of getNamedItems()' result, not needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 collection->namedItems(name, namedItems); 47 collection->namedItems(name, namedItems);
48 48
49 if (!namedItems.size()) 49 if (!namedItems.size())
50 return v8Undefined(); 50 return v8Undefined();
51 51
52 if (namedItems.size() == 1) 52 if (namedItems.size() == 1)
53 return toV8(namedItems.at(0).release(), info.Holder(), info.GetIsolate() ); 53 return toV8(namedItems.at(0).release(), info.Holder(), info.GetIsolate() );
54 54
55 // FIXME: HTML5 specification says this should be a HTMLCollection. 55 // FIXME: HTML5 specification says this should be a HTMLCollection.
56 // http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-in terfaces.html#htmlallcollection 56 // http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-in terfaces.html#htmlallcollection
57 // 57 return toV8(StaticElementList::adopt(namedItems), info.Holder(), info.GetIso late());
58 // FIXME: Oilpan: explicitly convert adopt()'s result so as to
59 // disambiguate the (implicit) conversion of its
60 // PassRefPtrWillBeRawPtr<StaticElementList> result -- the
61 // other toV8() overload that introduces the ambiguity is
62 // toV8(NodeList*, ...).
63 //
64 // When adopt() no longer uses transition types, the conversion
65 // can be removed.
66 return toV8(PassRefPtrWillBeRawPtr<NodeList>(StaticElementList::adopt(namedI tems)), info.Holder(), info.GetIsolate());
67 } 58 }
68 59
69 template<class CallbackInfo> 60 template<class CallbackInfo>
70 static v8::Local<v8::Value> getItem(HTMLAllCollection* collection, v8::Local<v8: :Value> argument, const CallbackInfo& info) 61 static v8::Local<v8::Value> getItem(HTMLAllCollection* collection, v8::Local<v8: :Value> argument, const CallbackInfo& info)
71 { 62 {
72 v8::Local<v8::Uint32> index; 63 v8::Local<v8::Uint32> index;
73 if (!argument->ToArrayIndex(info.GetIsolate()->GetCurrentContext()).ToLocal( &index)) { 64 if (!argument->ToArrayIndex(info.GetIsolate()->GetCurrentContext()).ToLocal( &index)) {
74 TOSTRING_DEFAULT(V8StringResource<>, name, argument, v8::Undefined(info. GetIsolate())); 65 TOSTRING_DEFAULT(V8StringResource<>, name, argument, v8::Undefined(info. GetIsolate()));
75 v8::Local<v8::Value> result = getNamedItems(collection, name, info); 66 v8::Local<v8::Value> result = getNamedItems(collection, name, info);
76 67
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 if (!info[1]->ToArrayIndex(info.GetIsolate()->GetCurrentContext()).ToLocal(& index)) 102 if (!info[1]->ToArrayIndex(info.GetIsolate()->GetCurrentContext()).ToLocal(& index))
112 return; 103 return;
113 104
114 if (Node* node = impl->namedItemWithIndex(name, index->Value())) { 105 if (Node* node = impl->namedItemWithIndex(name, index->Value())) {
115 v8SetReturnValueFast(info, node, impl); 106 v8SetReturnValueFast(info, node, impl);
116 return; 107 return;
117 } 108 }
118 } 109 }
119 110
120 } // namespace blink 111 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698