Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1130093009: Check the BrowserContext when ServiceWorkerHandler gets the ServiceWorkerDevToolsAgentHosts (Closed)

Created:
5 years, 7 months ago by horo
Modified:
5 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, kinuko+watch, aandrey+blink_chromium.org, pfeldman, serviceworker-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check the BrowserContext when ServiceWorkerHandler gets the ServiceWorkerDevToolsAgentHosts To avoid showing wrong ServiceWorkers which are in another profile in DevTooks window. BUG=488241 Committed: https://crrev.com/5bfeed4abb0d290d50142f2d8b2b8f8f19333f68 Cr-Commit-Position: refs/heads/master@{#330049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M content/browser/devtools/protocol/service_worker_handler.cc View 3 chunks +14 lines, -5 lines 0 comments Download
M content/browser/devtools/service_worker_devtools_manager.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/devtools/service_worker_devtools_manager.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
horo
pfeldman@ Could you please review this?
5 years, 7 months ago (2015-05-15 03:37:47 UTC) #2
pfeldman
lgtm
5 years, 7 months ago (2015-05-15 05:24:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130093009/1
5 years, 7 months ago (2015-05-15 05:54:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 05:57:41 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 05:58:21 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5bfeed4abb0d290d50142f2d8b2b8f8f19333f68
Cr-Commit-Position: refs/heads/master@{#330049}

Powered by Google App Engine
This is Rietveld 408576698