Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: content/browser/devtools/protocol/service_worker_handler.cc

Issue 1130093009: Check the BrowserContext when ServiceWorkerHandler gets the ServiceWorkerDevToolsAgentHosts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/devtools/service_worker_devtools_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/service_worker_handler.cc
diff --git a/content/browser/devtools/protocol/service_worker_handler.cc b/content/browser/devtools/protocol/service_worker_handler.cc
index 887300c619550cdef6dc1b6547cc74a5f5028a45..907d8a5f3439f9fee30b402a6975b33dbaa673c2 100644
--- a/content/browser/devtools/protocol/service_worker_handler.cc
+++ b/content/browser/devtools/protocol/service_worker_handler.cc
@@ -129,11 +129,14 @@ scoped_refptr<ServiceWorkerDevToolsAgentHost> GetMatchingServiceWorker(
}
ServiceWorkerDevToolsAgentHost::Map GetMatchingServiceWorkers(
+ BrowserContext* browser_context,
const std::set<GURL>& urls) {
- ServiceWorkerDevToolsAgentHost::List agent_hosts;
- ServiceWorkerDevToolsManager::GetInstance()->
- AddAllAgentHosts(&agent_hosts);
ServiceWorkerDevToolsAgentHost::Map result;
+ if (!browser_context)
+ return result;
+ ServiceWorkerDevToolsAgentHost::List agent_hosts;
+ ServiceWorkerDevToolsManager::GetInstance()
+ ->AddAllAgentHostsForBrowserContext(browser_context, &agent_hosts);
for (const GURL& url : urls) {
scoped_refptr<ServiceWorkerDevToolsAgentHost> host =
GetMatchingServiceWorker(agent_hosts, url);
@@ -213,14 +216,16 @@ void ServiceWorkerHandler::UpdateHosts() {
return;
urls_.clear();
+ BrowserContext* browser_context = nullptr;
if (render_frame_host_) {
render_frame_host_->frame_tree_node()->frame_tree()->ForEach(
base::Bind(&CollectURLs, &urls_));
+ browser_context = render_frame_host_->GetProcess()->GetBrowserContext();
}
ServiceWorkerDevToolsAgentHost::Map old_hosts = attached_hosts_;
ServiceWorkerDevToolsAgentHost::Map new_hosts =
- GetMatchingServiceWorkers(urls_);
+ GetMatchingServiceWorkers(browser_context, urls_);
for (auto pair : old_hosts) {
if (new_hosts.find(pair.first) == new_hosts.end())
@@ -463,7 +468,11 @@ void ServiceWorkerHandler::AgentHostClosed(
void ServiceWorkerHandler::WorkerCreated(
ServiceWorkerDevToolsAgentHost* host) {
- auto hosts = GetMatchingServiceWorkers(urls_);
+ BrowserContext* browser_context = nullptr;
+ if (render_frame_host_)
+ browser_context = render_frame_host_->GetProcess()->GetBrowserContext();
+
+ auto hosts = GetMatchingServiceWorkers(browser_context, urls_);
if (hosts.find(host->GetId()) != hosts.end() && !host->IsAttached() &&
!host->IsPausedForDebugOnStart())
host->PauseForDebugOnStart();
« no previous file with comments | « no previous file | content/browser/devtools/service_worker_devtools_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698