Support arrays in nonstd::unique_ptr<>.

Support arrays in nonstd::unique_ptr<>.

This mimics the std:: behaviour.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/21031ad28a73f0633e720997d310440c5bc31ec5

[Tom Sepez, 2015-05-06 23:51:13]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2015-05-06 23:51:14]

Lei, for review.  Thanks.

[Lei Zhang, 2015-05-06 23:59:36]

lgtm

Oh, I guess nonstd::unique_ptr doesn't do custom deleters yet. So we'll have to
add that if we want to use it with FX_ALLOC.

https://codereview.chromium.org/1130053003/diff/1/third_party/base/nonstd_uni...
File third_party/base/nonstd_unique_ptr.h (right):

https://codereview.chromium.org/1130053003/diff/1/third_party/base/nonstd_uni...
third_party/base/nonstd_unique_ptr.h:43: // dereference it, you get the
threadsafety guarantees of T.
nit: "thread safety"

https://codereview.chromium.org/1130053003/diff/1/third_party/base/nonstd_uni...
third_party/base/nonstd_unique_ptr.h:79: // arrays. These are diferenatiated
below based on the need to invoke
typo

[Tom Sepez, 2015-05-07 00:04:42]

> Oh, I guess nonstd::unique_ptr doesn't do custom deleters yet. So we'll have
to
> add that if we want to use it with FX_ALLOC.

Yeah, for most of these I'm expecting to do 
  unique_ptr<FX_FLOAT[]> floats(new FX_FLOAT[32]);
instead of the malloc.

While looking for FX_Alloc's to try this on, I found that this is a good
replacement
for the CFX_TempBuf<> class (which is unused).

[Tom Sepez, 2015-05-07 00:07:41]

See PS3

https://codereview.chromium.org/1130053003/diff/1/third_party/base/nonstd_uni...
File third_party/base/nonstd_unique_ptr.h (right):

https://codereview.chromium.org/1130053003/diff/1/third_party/base/nonstd_uni...
third_party/base/nonstd_unique_ptr.h:43: // dereference it, you get the
threadsafety guarantees of T.
On 2015/05/06 23:59:35, Lei Zhang wrote:
> nit: "thread safety"

Done.

https://codereview.chromium.org/1130053003/diff/1/third_party/base/nonstd_uni...
third_party/base/nonstd_unique_ptr.h:79: // arrays. These are diferenatiated
below based on the need to invoke
On 2015/05/06 23:59:35, Lei Zhang wrote:
> typo

Done.

[Lei Zhang, 2015-05-07 00:26:39]

lgtm

[Tom Sepez, 2015-05-07 00:29:34]

Committed patchset #3 (id:40001) manually as
21031ad28a73f0633e720997d310440c5bc31ec5 (presubmit successful).