Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: ui/views/widget/native_widget_aura.cc

Issue 1130033003: Make the minimize state work when creating a chrome window in CrOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase on master Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/native_widget_aura.cc
diff --git a/ui/views/widget/native_widget_aura.cc b/ui/views/widget/native_widget_aura.cc
index bf113e6e119de7bcb3ab99b2f21a1d185eba9ef7..a9205018b651b99d6715321a8a079565cd4851fe 100644
--- a/ui/views/widget/native_widget_aura.cc
+++ b/ui/views/widget/native_widget_aura.cc
@@ -484,8 +484,7 @@ void NativeWidgetAura::ShowWithWindowState(ui::WindowShowState state) {
if (!window_)
return;
- if (state == ui::SHOW_STATE_MAXIMIZED || state == ui::SHOW_STATE_FULLSCREEN)
- window_->SetProperty(aura::client::kShowStateKey, state);
+ window_->SetProperty(aura::client::kShowStateKey, state);
window_->Show();
if (delegate_->CanActivate()) {
if (state != ui::SHOW_STATE_INACTIVE)
@@ -495,6 +494,9 @@ void NativeWidgetAura::ShowWithWindowState(ui::WindowShowState state) {
// do the right thing.
SetInitialFocus(state);
}
+
+ if (state == ui::SHOW_STATE_MINIMIZED)
+ Minimize();
tapted 2015/05/28 23:55:02 Minimize() is literally `window_->SetProperty(aura
tapted 2015/05/29 00:02:16 (maybe you just need to include ui::SHOW_STATE_MIN
joone 2015/05/29 00:52:00 It works fine so I've uploaded the patch.
}
bool NativeWidgetAura::IsVisible() const {
« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698