Make the minimize state work when creating a chrome window in CrOS

ui/views/widget/native_widget_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/native_widget_aura.h"
 
 #include "base/bind.h"
 #include "base/strings/string_util.h"
 #include "third_party/skia/include/core/SkRegion.h"
 #include "ui/aura/client/aura_constants.h"
@@ skipping 466 matching lines @@
 void NativeWidgetAura::ShowMaximizedWithBounds(
     const gfx::Rect& restored_bounds) {
   SetRestoreBounds(window_, restored_bounds);
   ShowWithWindowState(ui::SHOW_STATE_MAXIMIZED);
 }
 
 void NativeWidgetAura::ShowWithWindowState(ui::WindowShowState state) {
   if (!window_)
     return;
 
-  if (state == ui::SHOW_STATE_MAXIMIZED || state == ui::SHOW_STATE_FULLSCREEN)
-    window_->SetProperty(aura::client::kShowStateKey, state);
+  window_->SetProperty(aura::client::kShowStateKey, state);
   window_->Show();
   if (delegate_->CanActivate()) {
     if (state != ui::SHOW_STATE_INACTIVE)
       Activate();
     // SetInitialFocus() should be always be called, even for
     // SHOW_STATE_INACTIVE. If the window has to stay inactive, the method will
     // do the right thing.
     SetInitialFocus(state);
   }
+
+  if (state == ui::SHOW_STATE_MINIMIZED)
+    Minimize();

[tapted, 2015/05/28 23:55:02]

Minimize() is literally `window_->SetProperty(aura::client::kShowStateKey,
ui::SHOW_STATE_MINIMIZED);` so this should be redundant with the change above,
unless something in between is "undoing" the minimize, which should be avoided.

Does it still work after removing this line?

[tapted, 2015/05/29 00:02:16]

(maybe you just need to include ui::SHOW_STATE_MINIMIZED in the `if (state !=
ui::SHOW_STATE_INACTIVE)` condition above? - that would make sense to me, but
sadrul might have other ideas :)

[joone, 2015/05/29 00:52:00]

It works fine so I've uploaded the patch.

 }
 
 bool NativeWidgetAura::IsVisible() const {
   return window_ && window_->IsVisible();
 }
 
 void NativeWidgetAura::Activate() {
   if (!window_)
     return;
 
@@ skipping 697 matching lines @@
   l10n_util::AdjustUIFont(&(ncm.lfCaptionFont));
   base::win::ScopedHFONT caption_font(CreateFontIndirect(&(ncm.lfCaptionFont)));
   return gfx::FontList(gfx::Font(caption_font));
 #else
   return gfx::FontList();
 #endif
 }
 
 }  // namespace internal
 }  // namespace views