Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1130003005: Change QuicNetworkTransactionTest member signatures. (Closed)

Created:
5 years, 7 months ago by Bence
Modified:
5 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change QuicNetworkTransactionTest member signatures. Change QuicNetworkTransactionTest::RunTransaction() and QuicNetworkTransactionTest::CheckResponseData() signatures to take HttpNetworkTransactions by scoped_ptr const reference instead of naked pointer to match four other members of the same testing class. BUG=474217 Committed: https://crrev.com/ffc2fdf533f11e26d89d3dc0ee20444012085bc1 Cr-Commit-Position: refs/heads/master@{#329883}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M net/quic/quic_network_transaction_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan: PTAL. Thanks.
5 years, 7 months ago (2015-05-14 18:06:21 UTC) #2
Ryan Hamilton
lgtm
5 years, 7 months ago (2015-05-14 18:12:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1130003005/1
5 years, 7 months ago (2015-05-14 18:23:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 18:29:57 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 18:31:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ffc2fdf533f11e26d89d3dc0ee20444012085bc1
Cr-Commit-Position: refs/heads/master@{#329883}

Powered by Google App Engine
This is Rietveld 408576698