Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Unified Diff: net/quic/quic_network_transaction_unittest.cc

Issue 1130003005: Change QuicNetworkTransactionTest member signatures. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_network_transaction_unittest.cc
diff --git a/net/quic/quic_network_transaction_unittest.cc b/net/quic/quic_network_transaction_unittest.cc
index ed7d8819295865a06052aaa2cb84837cb1bcfa5e..d3ca186b54ffc8bc010bcbf5d45d1a1a941e8432 100644
--- a/net/quic/quic_network_transaction_unittest.cc
+++ b/net/quic/quic_network_transaction_unittest.cc
@@ -279,14 +279,14 @@ class QuicNetworkTransactionTest
response->connection_info);
}
- void CheckResponseData(HttpNetworkTransaction* trans,
+ void CheckResponseData(const scoped_ptr<HttpNetworkTransaction>& trans,
const std::string& expected) {
std::string response_data;
- ASSERT_EQ(OK, ReadTransaction(trans, &response_data));
+ ASSERT_EQ(OK, ReadTransaction(trans.get(), &response_data));
EXPECT_EQ(expected, response_data);
}
- void RunTransaction(HttpNetworkTransaction* trans) {
+ void RunTransaction(const scoped_ptr<HttpNetworkTransaction>& trans) {
TestCompletionCallback callback;
int rv = trans->Start(&request_, callback.callback(), net_log_.bound());
EXPECT_EQ(ERR_IO_PENDING, rv);
@@ -296,9 +296,9 @@ class QuicNetworkTransactionTest
void SendRequestAndExpectHttpResponse(const std::string& expected) {
scoped_ptr<HttpNetworkTransaction> trans(
new HttpNetworkTransaction(DEFAULT_PRIORITY, session_.get()));
- RunTransaction(trans.get());
+ RunTransaction(trans);
CheckWasHttpResponse(trans);
- CheckResponseData(trans.get(), expected);
+ CheckResponseData(trans, expected);
}
void SendRequestAndExpectQuicResponse(const std::string& expected) {
@@ -376,10 +376,10 @@ class QuicNetworkTransactionTest
trans->SetBeforeProxyHeadersSentCallback(
base::Bind(&ProxyHeadersHandler::OnBeforeProxyHeadersSent,
base::Unretained(&proxy_headers_handler)));
- RunTransaction(trans.get());
+ RunTransaction(trans);
CheckWasQuicResponse(trans);
CheckResponsePort(trans, port);
- CheckResponseData(trans.get(), expected);
+ CheckResponseData(trans, expected);
EXPECT_EQ(used_proxy, proxy_headers_handler.was_called());
}
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698