Cleanup: Fix various coding style issues in src/untrusted/pthread

Cleanup: Fix various coding style issues in src/untrusted/pthread

This includes:

 * Fix comment style
 * Fix "*" spacing
 * Remove spaces before arguments (e.g. "foo ()")
 * Add punctuation to comments
 * Remove "__" prefixes from local variables

BUG=none
TEST=build

Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10380

[Roland McGrath, 2012-12-04 00:04:20]

LGTM.  Additional cosmetic cleanups below are optional (and I didn't cite every
case of the same issue).

https://codereview.chromium.org/11299315/diff/1/src/untrusted/pthread/nc_mutex.c
File src/untrusted/pthread/nc_mutex.c (right):

https://codereview.chromium.org/11299315/diff/1/src/untrusted/pthread/nc_mute...
src/untrusted/pthread/nc_mutex.c:144: int pthread_once(pthread_once_t
*__once_control,
It's also a style violation (or should be) that this is using __name for local
variables.

https://codereview.chromium.org/11299315/diff/1/src/untrusted/pthread/nc_thre...
File src/untrusted/pthread/nc_thread.c (right):

https://codereview.chromium.org/11299315/diff/1/src/untrusted/pthread/nc_thre...
src/untrusted/pthread/nc_thread.c:36: #define FUN_TO_VOID_PTR(a) ((void *)
((uintptr_t) a))
This also has superfluous parens around the second cast, but no parens around
the macro argument, where they could (depending on the usage) be needed.  i.e.
clean style would be: ((void *) (uintptr_t) (a))

https://codereview.chromium.org/11299315/diff/1/src/untrusted/pthread/nc_thre...
src/untrusted/pthread/nc_thread.c:114: /* If the function returns, terminate the
thread */
If you're going to capitalize, you might as well punctuate.

[Mark Seaborn, 2012-12-05 05:10:57]

https://codereview.chromium.org/11299315/diff/1/src/untrusted/pthread/nc_mutex.c
File src/untrusted/pthread/nc_mutex.c (right):

https://codereview.chromium.org/11299315/diff/1/src/untrusted/pthread/nc_mute...
src/untrusted/pthread/nc_mutex.c:144: int pthread_once(pthread_once_t
*__once_control,
On 2012/12/04 00:04:20, Roland McGrath wrote:
> It's also a style violation (or should be) that this is using __name for local
> variables.

Done.

https://codereview.chromium.org/11299315/diff/1/src/untrusted/pthread/nc_thre...
File src/untrusted/pthread/nc_thread.c (right):

https://codereview.chromium.org/11299315/diff/1/src/untrusted/pthread/nc_thre...
src/untrusted/pthread/nc_thread.c:36: #define FUN_TO_VOID_PTR(a) ((void *)
((uintptr_t) a))
On 2012/12/04 00:04:20, Roland McGrath wrote:
> This also has superfluous parens around the second cast, but no parens around
> the macro argument, where they could (depending on the usage) be needed.  i.e.
> clean style would be: ((void *) (uintptr_t) (a))

Done.

https://codereview.chromium.org/11299315/diff/1/src/untrusted/pthread/nc_thre...
src/untrusted/pthread/nc_thread.c:114: /* If the function returns, terminate the
thread */
On 2012/12/04 00:04:20, Roland McGrath wrote:
> If you're going to capitalize, you might as well punctuate.

Done.