Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 11299272: Revert 170406 - Align panel icons on the right / end. (Closed)

Created:
8 years ago by alexeypa (please no reviews)
Modified:
8 years ago
Reviewers:
flackr
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Revert 170406 - Align panel icons on the right / end. LauncherModel.AddIndices is failing in the bots: http://build.chromium.org/p/chromium.win/builders/Win%20Aura/builds/24835/steps/ash_unittests/logs/stdio BUG=160605 TEST=LauncherModel.AddIndices, LauncherViewTest.AddPanelHidesTabbedBrowser, LauncherViewTest.PanelsHideLast Review URL: https://chromiumcodereview.appspot.com/11348201 TBR=flackr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170420

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -149 lines) Patch
M ash/launcher/launcher_model.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/launcher/launcher_model.cc View 2 chunks +1 line, -9 lines 0 comments Download
M ash/launcher/launcher_model_unittest.cc View 2 chunks +7 lines, -13 lines 0 comments Download
M ash/launcher/launcher_view.cc View 8 chunks +15 lines, -31 lines 0 comments Download
M ash/launcher/launcher_view_unittest.cc View 9 chunks +4 lines, -90 lines 0 comments Download
M ash/shell/window_watcher.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
alexeypa (please no reviews)
8 years ago (2012-11-30 07:58:11 UTC) #1
alexeypa (please no reviews)
http://build.chromium.org/p/chromium.win/builders/Win%20Aura/builds/24835/steps/ash_unittests/logs/stdio: [ RUN ] LauncherModel.AddIndices [5980:2520:1129/222945:1585750:FATAL:launcher_model.cc(147)] Check failed: index >= 0 && index <= item_count(). ...
8 years ago (2012-11-30 08:00:45 UTC) #2
flackr
8 years ago (2012-11-30 13:41:59 UTC) #3
Message was sent while issue was closed.
LGTM thanks

Powered by Google App Engine
This is Rietveld 408576698