Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2368)

Unified Diff: ash/launcher/launcher_model_unittest.cc

Issue 11299272: Revert 170406 - Align panel icons on the right / end. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/launcher/launcher_model.cc ('k') | ash/launcher/launcher_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/launcher/launcher_model_unittest.cc
===================================================================
--- ash/launcher/launcher_model_unittest.cc (revision 170419)
+++ ash/launcher/launcher_model_unittest.cc (working copy)
@@ -175,9 +175,6 @@
int app_shortcut_index5 = model.AddAt(2, item);
EXPECT_EQ(browser + 2, app_shortcut_index5);
- // Before there are any panels, no icons should be right aligned.
- EXPECT_EQ(model.item_count(), model.FirstPanelIndex());
-
// Check that AddAt() figures out the correct indexes for tabs and panels.
item.type = TYPE_TABBED;
int tabbed_index3 = model.AddAt(2, item);
@@ -185,30 +182,27 @@
item.type = TYPE_APP_PANEL;
int app_panel_index1 = model.AddAt(2, item);
- EXPECT_EQ(browser + 10, app_panel_index1);
+ EXPECT_EQ(browser + 6, app_panel_index1);
item.type = TYPE_TABBED;
int tabbed_index4 = model.AddAt(11, item);
- EXPECT_EQ(browser + 9, tabbed_index4);
+ EXPECT_EQ(browser + 10, tabbed_index4);
item.type = TYPE_APP_PANEL;
- int app_panel_index2 = model.AddAt(15, item);
- EXPECT_EQ(browser + 12, app_panel_index2);
+ int app_panel_index2 = model.AddAt(12, item);
+ EXPECT_EQ(browser + 11, app_panel_index2);
item.type = TYPE_TABBED;
int tabbed_index5 = model.AddAt(7, item);
EXPECT_EQ(browser + 7, tabbed_index5);
item.type = TYPE_APP_PANEL;
- int app_panel_index3 = model.AddAt(13, item);
- EXPECT_EQ(browser + 13, app_panel_index3);
+ int app_panel_index3 = model.AddAt(8, item);
+ EXPECT_EQ(browser + 8, app_panel_index3);
- // Right aligned index should be the first app panel index.
- EXPECT_EQ(browser + 12, model.FirstPanelIndex());
-
// Browser shortcut and app list should still be first and second.
EXPECT_EQ(TYPE_BROWSER_SHORTCUT, model.items()[0].type);
- EXPECT_EQ(TYPE_APP_LIST, model.items()[model.FirstPanelIndex() - 1].type);
+ EXPECT_EQ(TYPE_APP_LIST, model.items()[model.items().size() - 1].type);
}
} // namespace ash
« no previous file with comments | « ash/launcher/launcher_model.cc ('k') | ash/launcher/launcher_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698