Chromium Code Reviews| Index: chrome/browser/ui/views/detachable_toolbar_view.cc |
| diff --git a/chrome/browser/ui/views/detachable_toolbar_view.cc b/chrome/browser/ui/views/detachable_toolbar_view.cc |
| index 354af9fac055e5979e2853922d0d59e2e3a77f98..f4be973dfbec63cbc16b57cb96d540c0f50c960e 100644 |
| --- a/chrome/browser/ui/views/detachable_toolbar_view.cc |
| +++ b/chrome/browser/ui/views/detachable_toolbar_view.cc |
| @@ -119,12 +119,13 @@ void DetachableToolbarView::PaintVerticalDivider(gfx::Canvas* canvas, |
| SkColor top_color, |
| SkColor middle_color, |
| SkColor bottom_color) { |
| + skia::RefPtr<SkShader> shader; |
|
sky
2012/11/29 23:54:56
Is there a reason for keeping this here and not at
danakj
2012/11/30 00:12:21
Nope, will move it.
|
| + |
| // Draw the upper half of the divider. |
| SkPaint paint; |
| - SkSafeUnref(paint.setShader(gfx::CreateGradientShader(vertical_padding + 1, |
| - height / 2, |
| - top_color, |
| - middle_color))); |
| + shader = gfx::CreateGradientShader( |
| + vertical_padding + 1, height / 2, top_color, middle_color); |
| + paint.setShader(shader.get()); |
| SkRect rc = { SkIntToScalar(x), |
| SkIntToScalar(vertical_padding + 1), |
| SkIntToScalar(x + 1), |
| @@ -133,8 +134,9 @@ void DetachableToolbarView::PaintVerticalDivider(gfx::Canvas* canvas, |
| // Draw the lower half of the divider. |
| SkPaint paint_down; |
| - SkSafeUnref(paint_down.setShader(gfx::CreateGradientShader( |
| - height / 2, height - vertical_padding, middle_color, bottom_color))); |
| + shader = gfx::CreateGradientShader( |
| + height / 2, height - vertical_padding, middle_color, bottom_color); |
| + paint_down.setShader(shader.get()); |
| SkRect rc_down = { SkIntToScalar(x), |
| SkIntToScalar(height / 2), |
| SkIntToScalar(x + 1), |