ui: Use skia::RefPtr<T> for implicit safe reference counting.

chrome/browser/ui/views/detachable_toolbar_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/detachable_toolbar_view.h"
 
 #include "chrome/browser/themes/theme_service.h"
 #include "grit/theme_resources.h"
 #include "third_party/skia/include/core/SkShader.h"
 #include "ui/base/resource/resource_bundle.h"
@@ skipping 101 matching lines @@
 }
 
 // static
 void DetachableToolbarView::PaintVerticalDivider(gfx::Canvas* canvas,
                                                  int x,
                                                  int height,
                                                  int vertical_padding,
                                                  SkColor top_color,
                                                  SkColor middle_color,
                                                  SkColor bottom_color) {
+  skia::RefPtr<SkShader> shader;

[sky, 2012/11/29 23:54:56]

Is there a reason for keeping this here and not at 126 where you create it?

[danakj, 2012/11/30 00:12:21]

Nope, will move it.

+
   // Draw the upper half of the divider.
   SkPaint paint;
-  SkSafeUnref(paint.setShader(gfx::CreateGradientShader(vertical_padding + 1,
-                                                        height / 2,
-                                                        top_color,
-                                                        middle_color)));
+  shader = gfx::CreateGradientShader(
+      vertical_padding + 1, height / 2, top_color, middle_color);
+  paint.setShader(shader.get());
   SkRect rc = { SkIntToScalar(x),
                 SkIntToScalar(vertical_padding + 1),
                 SkIntToScalar(x + 1),
                 SkIntToScalar(height / 2) };
   canvas->sk_canvas()->drawRect(rc, paint);
 
   // Draw the lower half of the divider.
   SkPaint paint_down;
-  SkSafeUnref(paint_down.setShader(gfx::CreateGradientShader(
-          height / 2, height - vertical_padding, middle_color, bottom_color)));
+  shader = gfx::CreateGradientShader(
+      height / 2, height - vertical_padding, middle_color, bottom_color);
+  paint_down.setShader(shader.get());
   SkRect rc_down = { SkIntToScalar(x),
                      SkIntToScalar(height / 2),
                      SkIntToScalar(x + 1),
                      SkIntToScalar(height - vertical_padding) };
   canvas->sk_canvas()->drawRect(rc_down, paint_down);
 }