Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11299219: Rework FocusManager as FocusClient. (Closed)

Created:
8 years ago by Ben Goodger (Google)
Modified:
8 years ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, jochen+watch_chromium.org
Visibility:
Public.

Description

Rework FocusManager as FocusClient. This allows us to have multiple focus system implementations. http://crbug.com/162100 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=169824

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -249 lines) Patch
M ash/display/screen_position_controller.cc View 1 2 3 4 5 3 chunks +7 lines, -5 lines 0 comments Download
M ash/extended_desktop_unittest.cc View 1 2 3 4 5 6 chunks +14 lines, -13 lines 0 comments Download
M ash/root_window_controller.cc View 1 2 3 4 5 3 chunks +4 lines, -4 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 1 2 3 4 5 2 chunks +2 lines, -3 lines 0 comments Download
M ash/shell.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shell.cc View 1 2 3 4 5 4 chunks +5 lines, -5 lines 0 comments Download
M ash/wm/activation_controller.h View 1 2 3 4 5 4 chunks +7 lines, -6 lines 0 comments Download
M ash/wm/activation_controller.cc View 1 2 3 4 5 4 chunks +9 lines, -8 lines 0 comments Download
M ash/wm/activation_controller_unittest.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/app_list_controller.h View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/app_list_controller.cc View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/custom_frame_view_ash_unittest.cc View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
M ash/wm/maximize_bubble_controller.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/window_manager_unittest.cc View 1 2 3 4 5 19 chunks +42 lines, -31 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 2 3 4 5 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 5 3 chunks +7 lines, -4 lines 0 comments Download
M content/shell/shell_stacking_client_ash.h View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M content/shell/shell_stacking_client_ash.cc View 1 2 3 4 5 1 chunk +2 lines, -3 lines 0 comments Download
M ui/aura/aura.gyp View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M ui/aura/bench/bench_main.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/aura/client/focus_change_observer.h View 1 2 3 4 5 2 chunks +6 lines, -4 lines 0 comments Download
A ui/aura/client/focus_client.h View 1 2 3 4 5 1 chunk +46 lines, -0 lines 0 comments Download
A ui/aura/client/focus_client.cc View 1 2 3 4 5 1 chunk +33 lines, -0 lines 0 comments Download
D ui/aura/focus_change_observer.h View 1 2 3 4 5 1 chunk +0 lines, -25 lines 0 comments Download
M ui/aura/focus_manager.h View 1 2 3 4 5 2 chunks +10 lines, -19 lines 0 comments Download
M ui/aura/focus_manager.cc View 1 2 3 4 5 3 chunks +13 lines, -11 lines 0 comments Download
M ui/aura/root_window.h View 1 2 3 4 5 4 chunks +0 lines, -7 lines 0 comments Download
M ui/aura/root_window.cc View 1 2 3 4 5 6 chunks +6 lines, -11 lines 0 comments Download
M ui/aura/root_window_unittest.cc View 1 2 3 4 5 3 chunks +9 lines, -5 lines 0 comments Download
M ui/aura/test/aura_test_helper.h View 1 2 3 4 5 3 chunks +5 lines, -5 lines 0 comments Download
M ui/aura/test/aura_test_helper.cc View 1 2 3 4 5 3 chunks +7 lines, -6 lines 0 comments Download
M ui/aura/window.h View 1 2 3 4 5 2 chunks +0 lines, -6 lines 0 comments Download
M ui/aura/window.cc View 1 2 3 4 5 2 chunks +8 lines, -15 lines 0 comments Download
M ui/views/controls/native/native_view_host_aura.cc View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/focus/focus_manager_unittest.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_activation_client.h View 1 2 3 4 5 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_activation_client.cc View 1 2 3 4 5 3 chunks +6 lines, -5 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_linux.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_linux.cc View 1 2 3 4 5 3 chunks +6 lines, -5 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_stacking_client.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_stacking_client.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 2 3 4 5 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
8 years ago (2012-11-27 23:28:27 UTC) #1
tfarina
Ben, did you forget to add focus_client.h? I don't see it in this CL nor ...
8 years ago (2012-11-27 23:58:56 UTC) #2
sky
8 years ago (2012-11-28 00:20:13 UTC) #3 
LGTM

https://codereview.chromium.org/11299219/diff/8008/ui/aura/window.cc
File ui/aura/window.cc (right):

https://codereview.chromium.org/11299219/diff/8008/ui/aura/window.cc#newcode541
ui/aura/window.cc:541: return client ? client->GetFocusedWindow() == this :
false;
nit: return client && client->Getfocusedwindow() == this

Powered by Google App Engine
This is Rietveld 408576698