Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(821)

Issue 1129893006: [Effen] Move 'flex' out of CSS also. (Closed)

Created:
5 years, 7 months ago by Hixie
Modified:
5 years, 7 months ago
Reviewers:
jamesr, eseidel
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

[Effen] Move 'flex' out of CSS also. This introduces a new kind of ContentNode similar to Style but which instead of changing the styles that apply to the node, provides new settings to apply to the "parentData" structure. If you have better ideas for the class names here let me know. Note that the layout.dart backend of this is hacky (more so than before, even); once we have something other than the DOM and CSS to back it, it'll get rewritten. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1a4db2e964de8a2eba7c76c0904027150cc0c387

Patch Set 1 #

Total comments: 1

Patch Set 2 : git cl land #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -6 lines) Patch
M sky/framework/components/action_bar.dart View 1 2 chunks +4 lines, -3 lines 0 comments Download
M sky/framework/fn.dart View 1 2 chunks +21 lines, -1 line 0 comments Download
M sky/framework/layout.dart View 4 chunks +36 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
eseidel
lgtm https://codereview.chromium.org/1129893006/diff/1/sky/framework/fn.dart File sky/framework/fn.dart (right): https://codereview.chromium.org/1129893006/diff/1/sky/framework/fn.dart#newcode151 sky/framework/fn.dart:151: class ParentDataStyler extends ContentNode { ParentDataSetter?
5 years, 7 months ago (2015-05-11 23:07:22 UTC) #2
Hixie
Committed patchset #2 (id:20001) manually as 1a4db2e964de8a2eba7c76c0904027150cc0c387 (presubmit successful).
5 years, 7 months ago (2015-05-11 23:20:24 UTC) #3
jamesr
I think this broke the tests: http://build.chromium.org/p/client.mojo/console Please use the trybots - all you have ...
5 years, 7 months ago (2015-05-12 00:06:02 UTC) #5
Hixie
5 years, 7 months ago (2015-05-12 17:20:22 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1122413006

Powered by Google App Engine
This is Rietveld 408576698