Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1122413006: [Effen] Move 'flex' out of CSS also. (mark II) (Closed)

Created:
5 years, 7 months ago by Hixie
Modified:
5 years, 7 months ago
Reviewers:
eseidel
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

[Effen] Move 'flex' out of CSS also. (mark II) This introduces a new kind of ContentNode similar to Style but which instead of changing the styles that apply to the node, provides new settings to apply to the "parentData" structure. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/31dde9c30bf5b61c2df7656d69c5174a887ccb74

Patch Set 1 #

Total comments: 3

Patch Set 2 : git cl description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -8 lines) Patch
M sky/framework/components/action_bar.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M sky/framework/fn.dart View 2 chunks +21 lines, -1 line 0 comments Download
M sky/framework/layout.dart View 1 4 chunks +39 lines, -2 lines 0 comments Download
M sky/tests/framework/basic.sky View 1 chunk +7 lines, -1 line 0 comments Download
M sky/tests/framework/basic-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
eseidel
lgtm https://codereview.chromium.org/1122413006/diff/1/sky/framework/layout.dart File sky/framework/layout.dart (right): https://codereview.chromium.org/1122413006/diff/1/sky/framework/layout.dart#newcode272 sky/framework/layout.dart:272: if (newStyle == null) dart doesn't have a ...
5 years, 7 months ago (2015-05-12 17:31:59 UTC) #2
Hixie
5 years, 7 months ago (2015-05-12 17:40:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
31dde9c30bf5b61c2df7656d69c5174a887ccb74 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698