Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 1129873002: Reland of Adding task runner/ message loop to tests that use IsolateHolder. (Closed)

Created:
5 years, 7 months ago by ssid
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, picksi1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of "Adding task runner/ message loop to tests that use IsolateHolder." Reason for reland: Fixed mac build. Original CL: crrev.com/1130433002 For adding v8 heap memory dump provider, the gin::IsolateHolder needs to have a task runner at initialization. The tests which don't initiallize task runner when initialization are changed in this CL to have either the message loop initializaed earlier or a dummy task runner. Refer crrev.com/1088683003 for the dump provider. BUG=476013 TBR=jochen@chromium.org,skyostil@chromium.org Committed: https://crrev.com/93b23d9f113f01c0c19078bed47a47283dec0fbd Cr-Commit-Position: refs/heads/master@{#328747}

Patch Set 1 #

Patch Set 2 : Moved using derivatives inside namespace. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -15 lines) Patch
M content/test/test_blink_web_unit_test_support.cc View 3 chunks +50 lines, -0 lines 0 comments Download
M gin/converter_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M gin/modules/module_registry_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M gin/modules/timer_unittest.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M gin/shell_runner_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M gin/test/v8_test.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
ssid
PTAL.
5 years, 7 months ago (2015-05-07 08:34:27 UTC) #4
Primiano Tucci (use gerrit)
LGTM. Given that this is a reland and the diff is one line change for ...
5 years, 7 months ago (2015-05-07 08:37:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129873002/60001
5 years, 7 months ago (2015-05-07 08:45:32 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/63391)
5 years, 7 months ago (2015-05-07 10:33:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1129873002/60001
5 years, 7 months ago (2015-05-07 12:07:42 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 7 months ago (2015-05-07 12:11:17 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 12:12:17 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/93b23d9f113f01c0c19078bed47a47283dec0fbd
Cr-Commit-Position: refs/heads/master@{#328747}

Powered by Google App Engine
This is Rietveld 408576698