gin/converter_unittest.cc - Issue 1129873002: Reland of Adding task runner/ message loop to tests that use IsolateHolder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/converter_unittest.cc

Issue 1129873002: Reland of Adding task runner/ message loop to tests that use IsolateHolder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved using derivatives inside namespace. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gin/converter_unittest.cc

diff --git a/gin/converter_unittest.cc b/gin/converter_unittest.cc

index 940d4a224a37a137aa3ef6b6fd21e74a041e007a..8b9adf414b05899eb85830f90414e95ca74d216e 100644

--- a/gin/converter_unittest.cc

+++ b/gin/converter_unittest.cc

@@ -14,6 +14,8 @@

#include "testing/gtest/include/gtest/gtest.h"

#include "v8/include/v8.h"

+namespace gin {

using v8::Array;

using v8::Boolean;

using v8::HandleScope;

@@ -26,8 +28,6 @@ using v8::String;

using v8::Undefined;

using v8::Value;

-namespace gin {

typedef V8Test ConverterTest;

TEST_F(ConverterTest, Bool) {

« no previous file with comments | « content/test/test_blink_web_unit_test_support.cc ('k') | gin/modules/module_registry_unittest.cc » ('j') | no next file with comments »